Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LanguageSettings.ps1 #12771

Merged
merged 5 commits into from
Jan 27, 2021
Merged

Update LanguageSettings.ps1 #12771

merged 5 commits into from
Jan 27, 2021

Conversation

chidozieononiwu
Copy link
Member

  • Add function for retrieving existing versions of packages

@chidozieononiwu chidozieononiwu force-pushed the UpdatesToLangSettingsFile branch 8 times, most recently from 4785a44 to 147ec32 Compare December 10, 2020 21:52
weshaggard
weshaggard approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable. Although you need to wait until your other changes (in particular the new Update-ChangeLog.ps1 in the tools repo)

@chidozieononiwu chidozieononiwu force-pushed the UpdatesToLangSettingsFile branch 2 times, most recently from 6a25639 to e003044 Compare December 12, 2020 03:42
@chidozieononiwu chidozieononiwu force-pushed the UpdatesToLangSettingsFile branch 4 times, most recently from 3ca761b to 52f16a5 Compare January 5, 2021 23:35
@chidozieononiwu chidozieononiwu force-pushed the UpdatesToLangSettingsFile branch from 52f16a5 to d1cde21 Compare January 26, 2021 21:04
@chidozieononiwu chidozieononiwu force-pushed the UpdatesToLangSettingsFile branch from d1cde21 to 4970733 Compare January 26, 2021 21:05
@chidozieononiwu chidozieononiwu merged commit 18ba5de into Azure:master Jan 27, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Feb 25, 2021
@levimm @alexeldeib
@JunSun17 @tilnl
CodeGen from PR 12771 in Azure/azure-rest-api-specs
5c48b4f 
Dev containerservice microsoft.container service 2021 02 01 (Azure#12771)

* Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01

* Updates readme

* Updates API version in new specs and examples

* aks: generate 2021-02-01 sdk (Azure#12311)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile`

* aks: add pod identity example

* AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361)

* add fqdnSubdomain for private cluster with custom private dns zone

* add example ref

* fix example

Co-authored-by: Li Ma <[email protected]>

* add new disk choice (Azure#12682)

* AKS: Add Node Public IP Prefix support. (Azure#12673)

* Add azure portal fqdn (Azure#12725)

* add azure portal fqdn

* add azure portal fqdn

* fix prettier

Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Ace Eldeib <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: tilnl <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 3, 2021
@levimm @alexeldeib
@JunSun17 @tilnl
CodeGen from PR 12771 in Azure/azure-rest-api-specs
b0a5e68 
Dev containerservice microsoft.container service 2021 02 01 (Azure#12771)

* Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01

* Updates readme

* Updates API version in new specs and examples

* aks: generate 2021-02-01 sdk (Azure#12311)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile`

* aks: add pod identity example

* AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361)

* add fqdnSubdomain for private cluster with custom private dns zone

* add example ref

* fix example

Co-authored-by: Li Ma <[email protected]>

* add new disk choice (Azure#12682)

* AKS: Add Node Public IP Prefix support. (Azure#12673)

* Add azure portal fqdn (Azure#12725)

* add azure portal fqdn

* add azure portal fqdn

* fix prettier

Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Ace Eldeib <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: tilnl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@mikeharder mikeharder Awaiting requested review from mikeharder

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chidozieononiwu @weshaggard