-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QnAMaker SDK Release #12311
Merged
Merged
QnAMaker SDK Release #12311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
joheredi
reviewed
Nov 5, 2020
@@ -2,7 +2,7 @@ | |||
"name": "@azure/cognitiveservices-qnamaker", | |||
"author": "Microsoft Corporation", | |||
"description": "QnAMakerClient Library with typescript type definitions for node.js and browser.", | |||
"version": "4.0.0", | |||
"version": "3.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we going backwards in the version number?
joheredi
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a comment regarding the version number
ramya-rao-a
approved these changes
Nov 5, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Feb 25, 2021
Dev containerservice microsoft.container service 2021 02 01 (Azure#12771) * Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01 * Updates readme * Updates API version in new specs and examples * aks: generate 2021-02-01 sdk (Azure#12311) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` * aks: add pod identity example * AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361) * add fqdnSubdomain for private cluster with custom private dns zone * add example ref * fix example Co-authored-by: Li Ma <[email protected]> * add new disk choice (Azure#12682) * AKS: Add Node Public IP Prefix support. (Azure#12673) * Add azure portal fqdn (Azure#12725) * add azure portal fqdn * add azure portal fqdn * fix prettier Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: tilnl <[email protected]>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Mar 3, 2021
Dev containerservice microsoft.container service 2021 02 01 (Azure#12771) * Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01 * Updates readme * Updates API version in new specs and examples * aks: generate 2021-02-01 sdk (Azure#12311) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` * aks: add pod identity example * AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361) * add fqdnSubdomain for private cluster with custom private dns zone * add example ref * fix example Co-authored-by: Li Ma <[email protected]> * add new disk choice (Azure#12682) * AKS: Add Node Public IP Prefix support. (Azure#12673) * Add azure portal fqdn (Azure#12725) * add azure portal fqdn * add azure portal fqdn * fix prettier Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: tilnl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #12298