Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QnAMaker SDK Release #12311

Merged
merged 2 commits into from
Nov 9, 2020
Merged

QnAMaker SDK Release #12311

merged 2 commits into from
Nov 9, 2020

Conversation

sarangan12
Copy link
Member

Duplicate of #12298

@sarangan12 sarangan12 mentioned this pull request Nov 5, 2020
@sarangan12 sarangan12 requested a review from joheredi November 5, 2020 19:41
@@ -2,7 +2,7 @@
"name": "@azure/cognitiveservices-qnamaker",
"author": "Microsoft Corporation",
"description": "QnAMakerClient Library with typescript type definitions for node.js and browser.",
"version": "4.0.0",
"version": "3.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we going backwards in the version number?

Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a comment regarding the version number

@sarangan12 sarangan12 merged commit 490e97a into Azure:master Nov 9, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Feb 25, 2021
Dev containerservice microsoft.container service 2021 02 01 (Azure#12771)

* Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01

* Updates readme

* Updates API version in new specs and examples

* aks: generate 2021-02-01 sdk (Azure#12311)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile`

* aks: add pod identity example

* AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361)

* add fqdnSubdomain for private cluster with custom private dns zone

* add example ref

* fix example

Co-authored-by: Li Ma <[email protected]>

* add new disk choice (Azure#12682)

* AKS: Add Node Public IP Prefix support. (Azure#12673)

* Add azure portal fqdn (Azure#12725)

* add azure portal fqdn

* add azure portal fqdn

* fix prettier

Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Ace Eldeib <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: tilnl <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 3, 2021
Dev containerservice microsoft.container service 2021 02 01 (Azure#12771)

* Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01

* Updates readme

* Updates API version in new specs and examples

* aks: generate 2021-02-01 sdk (Azure#12311)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile`

* aks: add pod identity example

* AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361)

* add fqdnSubdomain for private cluster with custom private dns zone

* add example ref

* fix example

Co-authored-by: Li Ma <[email protected]>

* add new disk choice (Azure#12682)

* AKS: Add Node Public IP Prefix support. (Azure#12673)

* Add azure portal fqdn (Azure#12725)

* add azure portal fqdn

* add azure portal fqdn

* fix prettier

Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Ace Eldeib <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: tilnl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants