[KeyVault] - Address a few items for keys and admin and bump service version #13759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorleger
requested review from
bterlson,
chradek,
sophiajt,
sadasant and
xirzec
as code owners
ghost
added
the
maorleger
commented
Feb 11, 2021
|
|
||
| // For convenience in this sample we'll use some self-signed test certificates | ||
| // that were generated using openssl | ||
| const samplePfxBase64 = |
There was a problem hiding this comment.
Looks suspicious but overall harmless - I just copied the same self signed test cert that dotnet uses instead of generating a different one https://github.com/Azure/azure-sdk-for-net/blob/311f34ea6ee203adb787b0319adf0415fbc30839/sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/samples/Sample3_ImportCertificate.cs#L99-L204
Debated between inlining these and making PEM and PFX files - but those are gitignored so I figured it's not worth constantly having to force add them. Let me know if you think otherwise!
maorleger
force-pushed
the
first-week-issues
branch
from
afbd357 to
f94b55e
Compare
maorleger
changed the title
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Apr 1, 2021
Update readme.python.md (Azure#13759)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
curvefromcreateECKeyOptionstocreateKeyOptionsCertificatePolicy.contentTypeis requiredWhy
createKeyOptionsis the catch-all and should accept parameters for all possible key creations (fixes [Key Vault Keys] createKey should accept "curve". #11263)Todo