Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service version to 7.2 #13594

Closed
maorleger opened this issue Feb 4, 2021 · 0 comments · Fixed by #13759
Closed

Update service version to 7.2 #13594

maorleger opened this issue Feb 4, 2021 · 0 comments · Fixed by #13759
Assignees
@maorleger
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] March

Comments

@maorleger
Copy link
Member

Currently it's 7.2-preview which we want to update to 7.2 sometime in the next release cycle (really I should have done this already but there's no harm in doing it in March - just not any later).

Check what the service version we want to use for KV Keys, certs, and secrets. Admin will be 7.2
@maorleger maorleger added Client This issue points to a problem in the data-plane of the library. KeyVault labels Feb 4, 2021
@maorleger maorleger added this to the [2021] March milestone Feb 4, 2021
@maorleger maorleger self-assigned this Feb 4, 2021
@maorleger maorleger added the blocking-release Blocks release label Feb 4, 2021
@maorleger maorleger mentioned this issue Feb 11, 2021
Merged
2 tasks
maorleger added a commit that referenced this issue Feb 16, 2021
@maorleger
[KeyVault] - Address a few items for keys and admin and bump service …
35fb851 
…version (#13759)

## What

- Move `curve` from `createECKeyOptions` to `createKeyOptions`
- Add sample clatifying when `CertificatePolicy.contentType` is required
- Bump the API version to 7.2 (and update recordings)

## Why

- `createKeyOptions` is the catch-all and should accept parameters for all possible key creations (fixes #11263)
- It's not entirely clear when contentType is required. Following dotnet's example here (fixes #12309)
- 7.2 is already supported, and we will not GA with 7.2-preview (fixes #13594)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] March
1 participant
@maorleger