[do not merge] App foundations primary issue #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzorz
changed the title
… better represent current internal project name status
Rename package from com.automattic.loop to com.automattic.portkey
Add linting and style rules
Set up basic CircleCI integration
…er into mp4composer
…ndling headless fragment
…BasicHandling.kt as we're not using it in the videoPlayer
…actor Simplified permission handling
App foundation: introducing CameraX
…the view hierarchy suffices to make the contained SurfaceTexture available
Untrack gradle.properties
Add app signing configurations to gradle build
…-cameraX-use Added safeguard code to re-create TextureView after using CameraX
…-image-capture Still image capture
|
|
!!!!!!
mzorz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will serve as the "feature" branch for the basic app.
app/foundationwill be receiving updates from other PRs as we move forward in implementation of the basic layoutapp/foundation-<description>and will add bits of behavior in order to get the main structure of the app in place. PRs using these subsequent branches should targetapp/foundation.Here's the tasks I have in mind for PRs targeting
app/foundation:use CameraX API (replace Camera2 with the CameraX wrapper)not doing this for now as per video use case not being available right nowended up doing it anyway as it'll become stable at some point, check App foundation: introducing CameraX #23 and Added safeguard code to re-create TextureView after using CameraX #25In a similar fashion, another set of branches targeting a different "feature" branch would take care of DB/network integration (i.e. FluxC integration) as part of the WP entities mapping work.
Also a different feature branch will be aiming at design and UI interactions when prototype design becomes available, and so on.
This PR specifically adds a new app skeleton, the first draft of the app. It only contains one Activity that performs no action.