Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename package from com.automattic.loop to com.automattic.portkey #3

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Rename package from com.automattic.loop to com.automattic.portkey #3

merged 2 commits into from
Jul 22, 2019

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Jul 19, 2019 •
edited
Loading

As discussed, this better represents current internal project name status and matches repo renaming.

@mzorz
renamed package from com.automattic.loop to com.automattic.portkey to…
d0edd33 
… better represent current internal project name status
@mzorz mzorz requested a review from aforcier July 19, 2019 14:48
@aforcier aforcier self-assigned this Jul 19, 2019
@aforcier
Copy link
Collaborator

Looks good @mzorz ! One last reference exists we should also update to portkey:

https://github.com/Automattic/portkey-android/blob/d0edd334bf219210ef276f12523cacbae8fbbe4a/app/src/main/res/values/strings.xml#L2

@aforcier aforcier mentioned this pull request Jul 19, 2019
Merged
@mzorz
Copy link
Contributor Author

mzorz commented Jul 20, 2019

Looks good @mzorz ! One last reference exists we should also update to portkey:

https://github.com/Automattic/portkey-android/blob/d0edd334bf219210ef276f12523cacbae8fbbe4a/app/src/main/res/values/strings.xml#L2

addressed in 39ae71f

@aforcier
Copy link
Collaborator

:shipit:

@aforcier aforcier merged commit cd295db into app/foundation Jul 22, 2019
@mzorz mzorz deleted the app/foundation-package-rename branch August 1, 2019 15:53
@aforcier aforcier added this to the Demo 1: Basic Creation milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aforcier aforcier Awaiting requested review from aforcier

Assignees

@aforcier aforcier

Labels
None yet
Projects
None yet
Milestone
Demo 1: Basic Creation
Development

Successfully merging this pull request may close these issues.
2 participants
@mzorz @aforcier