Add linting and style rules #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aforcier
changed the base branch from
app/foundation-package-rename
to
app/foundation
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up the standard a8c shared styles, along with checkstyle and ktlint. Also fixes a couple pre-existing violations and updates the
README.#3 should be merged first and the base branch of this PR updated.
Will configure CircleCI in a subsequent PR.
To test
./gradlew checkstyle, it should run and report violations (you'll have to make some violations)./gradlew ktlint, it should run and report violations (you'll have to make some violations)Note that you can run
./gradlew ktlintFormatand it'll automatically fix the violations it can.