Introduce mp4composer lib as a module #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pFrameActivity for saving video later
…fore advancing to record mode
7 tasks
mzorz
changed the title
…lAccessError due to unsupported access to Companion objects from Companion objects in Kotlin
…r wants to save without adding any views on top of original video
mzorz
changed the title
|
Looks good! |
(holding off until the entire stack has been merged)
aforcier
reviewed
Aug 12, 2019
photoeditor/build.gradle
Outdated
| @@ -42,6 +42,7 @@ dependencies { | |||
| testImplementation 'junit:junit:4.12' | |||
| androidTestImplementation 'androidx.test:runner:1.2.0' | |||
| androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0' | |||
| compile project(path: ':mp4compose') | |||
There was a problem hiding this comment.
compile is deprecated, this should be implementation project....
…-kotlin Convert mp4composer to Kotlin
|
Merged in #21 per our discussion to shorten the stack. Will merge this once CI clears it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Please Review and Merge #23, #22 and #21 first - do not merge until #21 gets merged here
Addresses #10
GlGifWatermarkFilterin 156a596To test:
0. open the app then tap on the floating buton to go to the composing screen
ToDo: