Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up basic CircleCI integration #5

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Set up basic CircleCI integration #5

merged 1 commit into from
Jul 22, 2019

Conversation

aforcier
Copy link
Collaborator

Configures the project to use CircleCI. Currently this will check that the project builds, and run the unit tests, checkstyle, ktlint, and lintRelease.

We can build on this later when we want to start running UI tests and do things like gradle.properties setup.

To test

  • Confirm that this PR passes CircleCI.
  • Observe that CircleCI failed for this test branch that intentionally broke unit tests, ktlint, and checkstyle

@aforcier aforcier requested a review from mzorz July 22, 2019 16:37
mzorz
mzorz approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, confirmed! :shipit:

@mzorz mzorz merged commit bced658 into app/foundation Jul 22, 2019
@mzorz mzorz deleted the circleci branch July 22, 2019 16:57
@aforcier aforcier added this to the Demo 1: Basic Creation milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Demo 1: Basic Creation
Development

Successfully merging this pull request may close these issues.
2 participants
@aforcier @mzorz