Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: Add actionable card for creating a Portfolio item when the post type is active #10936

Merged
merged 4 commits into from
Dec 11, 2018
Merged

Admin Page: Add actionable card for creating a Portfolio item when the post type is active #10936

merged 4 commits into from
Dec 11, 2018

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Dec 11, 2018 •
edited
Loading

Closes #10690.

Changes proposed in this Pull Request:

Testing instructions:

  • Checkout this branch
  • Visit the Jetpack settings page.
  • Confirm you see the actionable card if the post type is active.

Or launch a jn site with this branch

  • Connect the site
  • Check the Jetpack admin page (Writing Settings)
  • Activate deactivate Portfolios and confirm behaviour is the expected one.

Proposed changelog entry for your changes:

  • Added actionable card below the Jetpack settings card for Porfolio post types.

Screenshots

Design proposal in #10690

After

image

@oskosk oskosk added [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Dec 11, 2018
@oskosk oskosk requested a review from a team December 11, 2018 14:25
@oskosk oskosk mentioned this pull request Dec 11, 2018
Merged
@jetpackbot
Copy link

jetpackbot commented Dec 11, 2018 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against 00c07cd

@oskosk oskosk self-assigned this Dec 11, 2018
@oskosk oskosk added [Status] In Progress and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 11, 2018
@oskosk oskosk requested a review from jeherve December 11, 2018 16:10
@oskosk oskosk added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Dec 11, 2018
@oskosk oskosk requested a review from a team December 11, 2018 16:44
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 11, 2018
jeherve
jeherve previously requested changes Dec 11, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good; I would only have a few remarks.

_inc/client/writing/custom-content-types.jsx Outdated Show resolved Hide resolved
_inc/client/writing/custom-content-types.jsx Outdated Show resolved Hide resolved
@oskosk oskosk force-pushed the update/make-portfolios-actionable branch from 54d3579 to a23ea93 Compare December 11, 2018 17:28
@oskosk oskosk dismissed jeherve’s stale review December 11, 2018 17:33

Feedback was addressed

@oskosk oskosk added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 11, 2018
@oskosk oskosk changed the title Admin Page: Add actionable card for creating a Portfolio post when the post type is active Admin Page: Add actionable card for creating a Portfolio item when the post type is active Dec 11, 2018
@oskosk
Copy link
Contributor Author

oskosk commented Dec 11, 2018

@jeherve the weirdness you got to see in #10926... was it the blue border? or the face that the bottom border seems thinner ?

@jeherve
Copy link
Member

jeherve commented Dec 11, 2018

Just the blue border all around the card.

@oskosk
Copy link
Contributor Author

oskosk commented Dec 11, 2018 •
edited
Loading

The blue border seems to be expected because it's an <a> in the end. It's the same behaviour as with other action cards like in Sharing -> Sharing buttons for the "Configure your share buttons" card.

@oskosk oskosk added the [Status] Needs Design Review Design has been added. Needs a review! label Dec 11, 2018
keoshi
keoshi approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works even better! :shipit:

@oskosk oskosk added [Status] Design Review Complete and removed [Status] Needs Design Review Design has been added. Needs a review! labels Dec 11, 2018
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 11, 2018
jeherve
jeherve approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! This should be good to merge!

@oskosk oskosk merged commit 268d5d5 into master Dec 11, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 11, 2018
@oskosk oskosk deleted the update/make-portfolios-actionable branch December 11, 2018 19:47
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
Changelog: add #10936
1c3da14
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #10936
9fce18e
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@keoshi keoshi keoshi approved these changes

Assignees

@oskosk oskosk

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Status] Design Review Complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oskosk @jetpackbot @jeherve @keoshi @matticbot