Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Publicize Share Connection Toggle #10947

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Conversation

gititon
Copy link
Contributor

@gititon gititon commented Dec 11, 2018

When you first connect a social account via Publicize, you are presented with an option to share the connection among all authors. This will give all authors the ability to share their posts via this social media connection. Unfortunately, even when you enable this option, the setting doesn't save on WPCOM.

screen shot 2018-12-11 at 2 19 11 pm

Fixes #10930

Changes proposed in this Pull Request:

This PR ensures the correct Publicize Connection id is sent in the request to enable all authors to share the connection.

Testing instructions:

Spin up a JN site with the branch, here
Go to /wp-admin/options-general.php?page=sharing
Click the button to connect any service.
Go through the flow in the popup.
After connecting, enable the setting to make the connection global.
Close the popup
Open https://wordpress.com/sharing/your-domain
Expand the connection.
Ensure that it's set as shared/global.

Proposed changelog entry for your changes:

No changelog entry needed

@gititon gititon added [Feature] Publicize Now Jetpack Social, auto-sharing [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 11, 2018
@gititon gititon requested review from lezama, tyxla and a team December 11, 2018 19:19
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against bbf9f3a

@lezama
Copy link
Contributor

lezama commented Dec 11, 2018

Good catch! I wonder how long has this been around

@jeherve jeherve added this to the 6.9 milestone Dec 11, 2018
@jeherve jeherve added the [Type] Bug When a feature is broken and / or not performing as intended label Dec 11, 2018
@mdawaffe
Copy link
Member

Looks like I introduced the bug in 5d8f264.

@lezama lezama merged commit c585d87 into master Dec 11, 2018
@lezama lezama deleted the fixpublicize-global-share branch December 11, 2018 22:15
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👐

@jeherve jeherve removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 12, 2018
jeherve added a commit that referenced this pull request Dec 19, 2018
jeherve added a commit that referenced this pull request Jan 3, 2019
jeherve added a commit that referenced this pull request Jan 3, 2019
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing: Setting a Publicize connection as shared in wp-admin doesn't take
7 participants