Unlaunched sites: Set a blog option of "unlaunched" to sites that are created private #10560

scruffian · 2018-11-07T17:31:15Z

This will enable us to distinguish sites that are created private from sites that are deliberately private, so that we can show a coming soon page on them and a pre-launch banner.

This diff does several things:

It sets a blog option of launch-status to unlaunched when users create a site which is private.
It enables users to publish posts and pages to sites which have the launch-status blog option, even if their email address is unverified (this is OK because sites which are unlaunched aren't public, so there's no spam concerns, and they can't update the status to be launched without verifying their email address)
It returns the launch-status of a site in the API
Moves the functionality into a lib so we can use it in multiple places

Differential Revision: D19586-code

This commit syncs r182320-wpcom.

Fixes #

Changes proposed in this Pull Request:

Testing instructions:

Go to '..'

Proposed changelog entry for your changes:

… created private. This will enable us to distinguish sites that are created private from sites that are deliberately private, so that we can show a coming soon page on them and a pre-launch banner. This diff does several things: It sets a blog option of launch-status to unlaunched when users create a site which is private. It enables users to publish posts and pages to sites which have the launch-status blog option, even if their email address is unverified (this is OK because sites which are unlaunched aren't public, so there's no spam concerns, and they can't update the status to be launched without verifying their email address) It returns the launch-status of a site in the API Moves the functionality into a lib so we can use it in multiple places Differential Revision: D19586 This commit syncs r182320-wpcom.

jetpackbot · 2018-11-07T17:33:33Z

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS

jeherve

Just a quick question about the merge.

jeherve · 2018-11-07T17:39:48Z

json-endpoints/class.wpcom-json-api-get-site-endpoint.php

@@ -364,6 +366,9 @@ protected function render_response_key( $key, &$response, $is_user_logged_in ) {
 			case 'quota' :
 				$response[ $key ] = $this->site->get_quota();
 				break;
+			case 'launch_status' : 
+				$response[ $key ] = $this->site->get_launch_status();


I believe you may have to add get_launch_status() here as well:
https://github.com/Automattic/jetpack/blob/e9c0e0c1a02c07afed00e2c9d47d9b70184e6360/sal/class.json-api-site-base.php

matticbot · 2018-11-19T22:04:39Z

D21104-code. (newly created revision)

matticbot · 2018-12-04T11:46:42Z

D21770-code. (newly created revision)

dereksmart

Thank you!

* Add first version of the Changelog and testing list for 6.9 * Changelog: add #10710 * changelog: add #10538 * changelog: add #10741 * changelog: add #10749 * changelog: add #10664 * changelog: add #10224 * changelog: add #10788 * Changelog: add #10560 * Chanegelog: add #10812 * changelog: add #10556 * Changelog: add #10668 * Changelog: add #10846 * Changelog: add #10947 * Changelog: add #10962 * Changelog: add #10956 * Changelog: add #10940 * Changelog: add #10934 * Changelog: add #10912 * changelog: add #10866 * changelog: add #10924 * Changelog: add #10936 * Changelog: add #10833 * changelog: add #10867 * Changelog: add #10960 * Changelog: add #10888 * changelog: add #10840 * changelog: add #10972 * Changelog: add #10979 * changelog: add #10909 * Changelog: add #10958 * Changelog: add #10981 * Changelog: add #10564 * Changelog: add #10809 * Changelog: add #10982 * Changelog: add #10706 * Changelog: add #10978 * Changelog: add #10132 * Changelog: add #11022 * Changelog: add #11024 * Changelog: add #10875 * Changelog: add #11030 * Changelog: add #11053 * Changelog: add #10880 * Changelog: add #9359 * Changelog: add #11037 * Update block list * Changelog: add #11060 * Changelog: add #10755 * changelog: add #11000 * Changelog: add #10786 * Changelog: add #10945 * Changelog: add #10597

scruffian requested a review from a team November 7, 2018 17:31

matticbot added the Touches WP.com Files label Nov 7, 2018

scruffian self-assigned this Nov 7, 2018

jeherve added [Feature] WPCOM API [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Dotcom Merge [Status] Tested on WP.com labels Nov 7, 2018

jeherve added this to the 6.8 milestone Nov 7, 2018

jeherve reviewed Nov 7, 2018

View reviewed changes

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 16, 2018

oskosk changed the title ~~Unlaunched sites: Set a blog option of "unlaunched" to sites that are…~~ Unlaunched sites: Set a blog option of "unlaunched" to sites that are created private Nov 19, 2018

jeherve removed this from the 6.8 milestone Nov 20, 2018

scruffian mentioned this pull request Dec 4, 2018

File Sync - Unlaunched sites: Set a blog option of "unlaunched" to sites that are created private. #10791

Closed

Add the functon to the API base

2370ab3

dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 4, 2018

dereksmart approved these changes Dec 4, 2018

View reviewed changes

dereksmart merged commit 9013fdf into master Dec 4, 2018

matticbot added the [Status] Needs Changelog label Dec 4, 2018

dereksmart deleted the sync/scruffian/r182320-wpcom-1541611833 branch December 4, 2018 14:09

ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 4, 2018

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Dec 7, 2018

jeherve added a commit that referenced this pull request Dec 19, 2018

Changelog: add #10560

318818e

jeherve added a commit that referenced this pull request Jan 3, 2019

Changelog: add #10560

6da94f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unlaunched sites: Set a blog option of "unlaunched" to sites that are created private #10560

Unlaunched sites: Set a blog option of "unlaunched" to sites that are created private #10560

scruffian commented Nov 7, 2018 •

edited by oskosk

Loading

jetpackbot commented Nov 7, 2018 •

edited

Loading

jeherve left a comment

jeherve Nov 7, 2018

matticbot commented Nov 19, 2018

matticbot commented Dec 4, 2018

dereksmart left a comment

Unlaunched sites: Set a blog option of "unlaunched" to sites that are created private #10560

Unlaunched sites: Set a blog option of "unlaunched" to sites that are created private #10560

Conversation

scruffian commented Nov 7, 2018 • edited by oskosk Loading

Changes proposed in this Pull Request:

Testing instructions:

Proposed changelog entry for your changes:

jetpackbot commented Nov 7, 2018 • edited Loading

jeherve left a comment

Choose a reason for hiding this comment

jeherve Nov 7, 2018

Choose a reason for hiding this comment

matticbot commented Nov 19, 2018

matticbot commented Dec 4, 2018

dereksmart left a comment

Choose a reason for hiding this comment

scruffian commented Nov 7, 2018 •

edited by oskosk

Loading

jetpackbot commented Nov 7, 2018 •

edited

Loading