Resp. videos: don't load if theme supports core responsive embeds #10880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10678 If a theme already includes support for Core's Responsive Embeds feature, they don't need our implementation.
jeherve
added
[Type] Bug
|
D22005-code. (newly created revision) |
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 10, 2019. Generated by 🚫 dangerJS |
|
Awesome work |
brbrr
added
[Status] Ready to Merge
ghost
removed
[Status] Needs Changelog
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Jan 3, 2019
* Add first version of the Changelog and testing list for 6.9 * Changelog: add #10710 * changelog: add #10538 * changelog: add #10741 * changelog: add #10749 * changelog: add #10664 * changelog: add #10224 * changelog: add #10788 * Changelog: add #10560 * Chanegelog: add #10812 * changelog: add #10556 * Changelog: add #10668 * Changelog: add #10846 * Changelog: add #10947 * Changelog: add #10962 * Changelog: add #10956 * Changelog: add #10940 * Changelog: add #10934 * Changelog: add #10912 * changelog: add #10866 * changelog: add #10924 * Changelog: add #10936 * Changelog: add #10833 * changelog: add #10867 * Changelog: add #10960 * Changelog: add #10888 * changelog: add #10840 * changelog: add #10972 * Changelog: add #10979 * changelog: add #10909 * Changelog: add #10958 * Changelog: add #10981 * Changelog: add #10564 * Changelog: add #10809 * Changelog: add #10982 * Changelog: add #10706 * Changelog: add #10978 * Changelog: add #10132 * Changelog: add #11022 * Changelog: add #11024 * Changelog: add #10875 * Changelog: add #11030 * Changelog: add #11053 * Changelog: add #10880 * Changelog: add #9359 * Changelog: add #11037 * Update block list * Changelog: add #11060 * Changelog: add #10755 * changelog: add #11000 * Changelog: add #10786 * Changelog: add #10945 * Changelog: add #10597
jeherve
added a commit
that referenced
this pull request
Jan 21, 2019
Fixes #11097 This is a different approach than #10880. Instead of shortcircuiting Jetpack responsive videos as soon as we detect that the theme supports core responsive embeds, we check the HTML content of each post for blocks. If we find blocks, and if we find embed blocks among those, we do not use Jetpack responsive videos. If however all we find are classic blocks (even with videos inside) or shortcodes, we carry on and use Jetpack responsive videos.
jeherve
added a commit
that referenced
this pull request
Jan 29, 2019
* Responsive videos: do not load when embed blocks are in use Fixes #11097 This is a different approach than #10880. Instead of shortcircuiting Jetpack responsive videos as soon as we detect that the theme supports core responsive embeds, we check the HTML content of each post for blocks. If we find blocks, and if we find embed blocks among those, we do not use Jetpack responsive videos. If however all we find are classic blocks (even with videos inside) or shortcodes, we carry on and use Jetpack responsive videos. * Responsive Videos: rm Jetpack wrapper around embed blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10678
Fixes Automattic/wp-calypso#28323
Changes proposed in this Pull Request:
If a theme already includes support for Core's Responsive Embeds feature, they don't need our implementation.
Testing instructions:
Proposed changelog entry for your changes: