Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: Add actionable card for creating a Testimonial post when the post type is active #10926

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Admin Page: Add actionable card for creating a Testimonial post when the post type is active #10926

merged 2 commits into from
Dec 11, 2018

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Dec 10, 2018 •
edited
Loading

Addresses #10690 partially.

Changes proposed in this Pull Request:

  • Adds actionable card below the testimonial setting card.

Testing instructions:

  • Checkout this branch
  • Visit the Jetpack settings page.
  • Confirm you see the actionable card if the post type is active.

Or launch a jn site with this branch

  • Connect the site
  • Check the Jetpack admin page (Writing Settings)
  • Activate deactivate Testimonial and confirm behaviour is the expected one.

Proposed changelog entry for your changes:

  • Added actionable card below the Jetpack settings card for Testimonial post types.

Screenshots

Design proposal in #10690

After

Testimonials active

image

@oskosk oskosk requested a review from a team December 10, 2018 22:33
@oskosk oskosk added [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. Admin Page React-powered dashboard under the Jetpack menu labels Dec 10, 2018
@oskosk oskosk changed the title Admin Page Add actionable card for wirting a Testimonial when the post type is active Admin Page: Add actionable card for creating a Testimonial post when the post type is active Dec 10, 2018
oskosk
oskosk commented Dec 10, 2018
View reviewed changes
_inc/client/writing/custom-content-types.jsx
{
this.props.testimonialActive && (
<CompactCard
className="jp-settings-card__configure-link"
Copy link
Contributor Author

@oskosk oskosk Dec 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class may not be needed. Will double check

@jetpackbot
Copy link
Collaborator

jetpackbot commented Dec 10, 2018 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against 613994a

@oskosk oskosk self-assigned this Dec 11, 2018
@oskosk oskosk added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! and removed [Status] In Progress labels Dec 11, 2018
keoshi
keoshi previously approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great in my testing! We should do the same for the Portfolio CPT.

@oskosk oskosk force-pushed the update/make-testimonial-actionable branch from b8d2aeb to 613994a Compare December 11, 2018 13:32
@oskosk oskosk mentioned this pull request Dec 11, 2018
Merged
@oskosk
Copy link
Contributor Author

oskosk commented Dec 11, 2018

Thanks @keoshi ! Will address the portfolio version in #10936

@oskosk oskosk removed the [Status] Needs Design Review Design has been added. Needs a review! label Dec 11, 2018
@oskosk oskosk requested review from jeherve and a team December 11, 2018 16:11
jeherve
jeherve approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work well in my tests, although I spotted a weird effect when clicking on the link:

screenshot 2018-12-11 at 18 04 12

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 11, 2018
@oskosk
Copy link
Contributor Author

oskosk commented Dec 11, 2018

Thanks @jeherve . Will address that border issue in #10936 for both cards

@oskosk oskosk merged commit b5964de into master Dec 11, 2018
@ghost ghost removed [Status] Needs Changelog [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 11, 2018
@oskosk oskosk deleted the update/make-testimonial-actionable branch December 11, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@keoshi keoshi keoshi left review comments

Assignees

@oskosk oskosk

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oskosk @jetpackbot @keoshi @jeherve @matticbot