forked from nusCS2113-AY1920S1/PersonalAssistant-Duke
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loan GUI display on add/delete loan + prevent editing stockCode #378
Merged
yanprosobo
merged 22 commits into
AY1920S1-CS2113T-F09-3:master
from
cyanoei:loan_gui_fix
Nov 9, 2019
Merged
Loan GUI display on add/delete loan + prevent editing stockCode #378
yanprosobo
merged 22 commits into
AY1920S1-CS2113T-F09-3:master
from
cyanoei:loan_gui_fix
Nov 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete parser_seq.png
* 'master' of https://github.com/cyanoei/duke-team: Delete parser_seq.png Add files via upload
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Fixed error with loading of stock from .csv (AY1920S1-CS2113T-F09-3#278) List stocktype multi args (AY1920S1-CS2113T-F09-3#275) Ug in Markdown (AY1920S1-CS2113T-F09-3#276) Input fix for cross-platform use cases (AY1920S1-CS2113T-F09-3#277)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Add static CommandDictionary method to get standardized command usage messages (AY1920S1-CS2113T-F09-3#283) Ui.png update (AY1920S1-CS2113T-F09-3#282) Test commands (AY1920S1-CS2113T-F09-3#280) Help YanBo tag his code (AY1920S1-CS2113T-F09-3#279)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: List all loans (AY1920S1-CS2113T-F09-3#347) List personloans (AY1920S1-CS2113T-F09-3#346) Loan add backend (AY1920S1-CS2113T-F09-3#345) Update help txt till v1.3.0 (AY1920S1-CS2113T-F09-3#343) Add command history and caret movement (AY1920S1-CS2113T-F09-3#286)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Implemented list template functions (AY1920S1-CS2113T-F09-3#354) Fix bugs (shown in comments) (AY1920S1-CS2113T-F09-3#352) Implemented add template functionality (AY1920S1-CS2113T-F09-3#349) UG improvements. (AY1920S1-CS2113T-F09-3#350)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Implemented ability to add new loans using templates (AY1920S1-CS2113T-F09-3#357)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Loans update (AY1920S1-CS2113T-F09-3#361) Fix bugs (see comments) (AY1920S1-CS2113T-F09-3#358)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Ug update 7 nov (AY1920S1-CS2113T-F09-3#364) Loans update (AY1920S1-CS2113T-F09-3#362)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Find description command (AY1920S1-CS2113T-F09-3#367)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Delete template person (AY1920S1-CS2113T-F09-3#368) Implement minimum required quantity (AY1920S1-CS2113T-F09-3#370) Save LoanList PersonList TemplateList (AY1920S1-CS2113T-F09-3#366)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Add list stocks below minimum (AY1920S1-CS2113T-F09-3#371)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Minor additions to Template features (AY1920S1-CS2113T-F09-3#376)
…_fix * commit 'acf7ed9ccd6c5bccce648bc7257698a6d37e99a1': Add shopping list + update command dictionary (AY1920S1-CS2113T-F09-3#373)
yanprosobo
approved these changes
Nov 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do make sure help command knows what you can edit by adding "*" before commands that are not usable. Else all looks good.
cyanoei
added a commit
to cyanoei/eggventory-team
that referenced
this pull request
Nov 9, 2019
* commit '2005feefbe6457e03a79b7272598c2a789f53b7e': Loan GUI display on add/delete loan + prevent editing stockCode (AY1920S1-CS2113T-F09-3#378) Find gui (AY1920S1-CS2113T-F09-3#374)
cyanoei
added a commit
to cyanoei/eggventory-team
that referenced
this pull request
Nov 9, 2019
… into bug_fixes * 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Ug update1.3.5 (AY1920S1-CS2113T-F09-3#382) Ug update - please approve my other PRs first (AY1920S1-CS2113T-F09-3#380) Loan GUI display on add/delete loan + prevent editing stockCode (AY1920S1-CS2113T-F09-3#378) Find gui (AY1920S1-CS2113T-F09-3#374) Add shopping list + update command dictionary (AY1920S1-CS2113T-F09-3#373)
cyanoei
added a commit
to cyanoei/eggventory-team
that referenced
this pull request
Nov 9, 2019
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Readme update (AY1920S1-CS2113T-F09-3#383) Ug update1.3.5 (AY1920S1-CS2113T-F09-3#382) Ug update - please approve my other PRs first (AY1920S1-CS2113T-F09-3#380) Loan GUI display on add/delete loan + prevent editing stockCode (AY1920S1-CS2113T-F09-3#378) Find gui (AY1920S1-CS2113T-F09-3#374) Add shopping list + update command dictionary (AY1920S1-CS2113T-F09-3#373)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.