Implemented ability to add new loans using templates #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deculsion
changed the title
cyanoei
reviewed
Nov 6, 2019
| @@ -18,7 +18,7 @@ public CommandDictionary() { | |||
| // Add Commands | |||
| commandDict.add(new Pair<>("add stock", "<StockType> <StockCode> <Quantity> <Description>")); | |||
| commandDict.add(new Pair<>("add stocktype", "<StockType>")); | |||
| commandDict.add(new Pair<>("add loan", "<StockCode> <Quantity>")); | |||
| commandDict.add(new Pair<>("add loan", "<MatricNo> <StockCode> <Quantity>")); | |||
cyanoei
reviewed
Nov 6, 2019
|
|
||
| import javax.imageio.ImageTranscoder; | ||
| import java.util.ArrayList; | ||
|
|
cyanoei
reviewed
Nov 6, 2019
| String[] addInput = input.split(" +"); | ||
| if (Parser.isReserved(addInput[0])) { | ||
| throw new BadInputException("'" + addInput[0] + "' is an invalid name as it is a keyword" | ||
| + " for an existing command."); | ||
| } | ||
|
|
||
| if (TemplateList.templateExists(addInput[1])) { | ||
| return new AddLoanByTemplateCommand(CommandType.ADD, addInput[0], addInput[1]); |
cyanoei
added a commit
to cyanoei/eggventory-team
that referenced
this pull request
Nov 6, 2019
… into bug_hunting_2 * 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Implemented ability to add new loans using templates (AY1920S1-CS2113T-F09-3#357)
cyanoei
added a commit
to cyanoei/eggventory-team
that referenced
this pull request
Nov 6, 2019
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Implemented ability to add new loans using templates (AY1920S1-CS2113T-F09-3#357)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #348