List personloans #346
Merged
List personloans #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into list-personloans
… into list-personloans
… into list-personloans
cyanoei
reviewed
Nov 5, 2019
| @@ -29,12 +30,28 @@ private Command processListStockType(String input) throws BadInputException { | |||
| } | |||
|
|
|||
| private Command processListPerson(String input) throws BadInputException { | |||
| String[] inputArr = input.split(" +"); | |||
| String[] inputArr = input.split(" "); | |||
There was a problem hiding this comment.
mm i've noticed that the predictive search (however raghav did it) prevents users from spamming spaces between their params anyway, so the multiple spaces regex has truly become obsolete
cyanoei
approved these changes
Nov 5, 2019
cyanoei
added a commit
to cyanoei/eggventory-team
that referenced
this pull request
Nov 5, 2019
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: List all loans (AY1920S1-CS2113T-F09-3#347) List personloans (AY1920S1-CS2113T-F09-3#346) Loan add backend (AY1920S1-CS2113T-F09-3#345) Update help txt till v1.3.0 (AY1920S1-CS2113T-F09-3#343) Add command history and caret movement (AY1920S1-CS2113T-F09-3#286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function to list one person's loans