Loan add backend #345
Loan add backend #345
Conversation
… into list-personloans
… into list-personloans
… into list-personloans
| @@ -39,6 +39,7 @@ public CommandDictionary() { | |||
| commandDict.add(new Pair<>("list template", null)); | |||
| commandDict.add(new Pair<>("list lost", null)); | |||
| commandDict.add(new Pair<>("list person", null)); | |||
| commandDict.add(new Pair<>("list person", "<MatricNo>")); | |||
There was a problem hiding this comment.
hmmmmmm. isn't this a form of list loan? to discuss irl.
| @@ -45,16 +52,18 @@ private boolean sufficientStock() { | |||
| */ | |||
| public String execute(StockList list, Ui ui, Storage storage) { | |||
| String output = ""; | |||
| if (sufficientStock()) { | |||
| if (!stockExists()) { | |||
| return new ListPersonCommand(CommandType.LIST); | ||
| case 2: | ||
| return new ListPersonLoansCommand(CommandType.LIST, inputArr[1]); | ||
| default: |
There was a problem hiding this comment.
interesting implementation, but i'm not sure if we should change this to "list person all" and "list person [matric]" similar to the list stocktype issue. would be an easy change both ways tho
| */ | ||
| public static int getLoanQuantity(String stockCode, String matricNo) { | ||
| public static int getPersonLoanQuantity(String stockCode, String matricNo) { |
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: List all loans (AY1920S1-CS2113T-F09-3#347) List personloans (AY1920S1-CS2113T-F09-3#346) Loan add backend (AY1920S1-CS2113T-F09-3#345) Update help txt till v1.3.0 (AY1920S1-CS2113T-F09-3#343) Add command history and caret movement (AY1920S1-CS2113T-F09-3#286)
| @@ -69,5 +70,6 @@ public String execute(StockList list, Ui ui, Storage storage) throws BadInputExc | |||
| */ | |||
| public void execute(StockList list) { | |||
| list.addStock(stockType, stockCode, quantity, description); | |||
| LoanList.addStock(stockCode, quantity); | |||
There was a problem hiding this comment.
so i realise that this is only implemented in one execute but not the other - theres two execute functions for normal adding versus for adding from storage, and this is only the storage one.
i will add this line into the other execute method as well in a future update.
There was a problem hiding this comment.
but also not sure if its more efficient to just add stocks to the loan's quantity list only when they are first ever loaned out? cos this current method requires the loanlist to quietly be updated when stocks are first added, which... doesn't quite feel necessary to me
No description provided.