Fix bugs (see comments) #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanoei
commented
Nov 6, 2019
cyanoei
commented
- fixes: add stocktype fails if the stocktype is not a single word #313 - stocktypes are now restricted to single word input (no spaces allowed). exceptions are thrown accordingly.
- fixes: [Bug] Names can only be one word long #335 - person's name can have spaces inside.
Delete parser_seq.png
* 'master' of https://github.com/cyanoei/duke-team: Delete parser_seq.png Add files via upload
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Fixed error with loading of stock from .csv (AY1920S1-CS2113T-F09-3#278) List stocktype multi args (AY1920S1-CS2113T-F09-3#275) Ug in Markdown (AY1920S1-CS2113T-F09-3#276) Input fix for cross-platform use cases (AY1920S1-CS2113T-F09-3#277)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Add static CommandDictionary method to get standardized command usage messages (AY1920S1-CS2113T-F09-3#283) Ui.png update (AY1920S1-CS2113T-F09-3#282) Test commands (AY1920S1-CS2113T-F09-3#280) Help YanBo tag his code (AY1920S1-CS2113T-F09-3#279)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: List all loans (AY1920S1-CS2113T-F09-3#347) List personloans (AY1920S1-CS2113T-F09-3#346) Loan add backend (AY1920S1-CS2113T-F09-3#345) Update help txt till v1.3.0 (AY1920S1-CS2113T-F09-3#343) Add command history and caret movement (AY1920S1-CS2113T-F09-3#286)
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Implemented list template functions (AY1920S1-CS2113T-F09-3#354) Fix bugs (shown in comments) (AY1920S1-CS2113T-F09-3#352) Implemented add template functionality (AY1920S1-CS2113T-F09-3#349) UG improvements. (AY1920S1-CS2113T-F09-3#350)
…ng multiple word inputs
… into bug_hunting_2 * 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Implemented ability to add new loans using templates (AY1920S1-CS2113T-F09-3#357)
yanprosobo
approved these changes
Nov 7, 2019
cyanoei
added a commit
to cyanoei/eggventory-team
that referenced
this pull request
Nov 7, 2019
… into loans_update * 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Fix bugs (see comments) (AY1920S1-CS2113T-F09-3#358)
cyanoei
added a commit
to cyanoei/eggventory-team
that referenced
this pull request
Nov 7, 2019
* 'master' of https://github.com/AY1920S1-CS2113T-F09-3/main: Loans update (AY1920S1-CS2113T-F09-3#361) Fix bugs (see comments) (AY1920S1-CS2113T-F09-3#358)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.