-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy RC 435 to Production #11584
Merged
Merged
Deploy RC 435 to Production #11584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are planning to validate additional data that appears on the state ID with the issuing source via DLDV. In order to facilitate this new feature this change adds fields for the new attributes to the `StateId` struct. This struct is used to represent the State ID data when it is in the IdV session. [skip changelog]
changelog: Internal, Deploy, Fetch latest origin as part of deploy PR script
changelog: Upcoming Features, Socure, Model Socure shadow mode as an A/B test
In #11559 we will be reading new attributes from the document during document authentication. This commit updates the doc auth mock client to match this behavior. This will help us identify any issues these new attributes may cause in lower environments. [skip changelog]
* changelog: Internal, Reporting, feature flag Adding Feature flag to table summary export job to prevent errors in New Relic in elevated environments --------- Co-authored-by: Zach Margolis <[email protected]> Co-authored-by: Aaron Nagucki <[email protected]>
… do so (#11559) We are working to send additional data to AAMVA when it is present on documents. This commit lays groundwork for this by reading those new attributes when configured to do so. We are waiting on security approval before we start writing these new attributes into the Login.gov session. For that reason the reading of these attributes is feature flagged and disabled by default. changelog: Internal, Document Authentication, Read additional document data from TrueID when configured to do so * cleanup
* changelog: User-Facing Improvements, Authentication, SP Email Selection max email limit * rubocop fixes * Add check for when user goes through completion screen * add spec for making sure variable is being assigned
* added method definition * changelog: Upcoming Features, socure, socure analytics logging * Resolving pr comments, still needs work * Try to fix test * still trying * Moving test and adding tests * Fixing lint * Resolving Pr comments, fixing perform later * Resolving PR comments * cleaning up varibles and using extra_attributes method * Resolving PR comments * Removing certain nil attributes and resolving PR comments, making more readable * Resolving pr comments removing unneeded code * Fixing rebase * Resolving PR request for adding logging test to feature test * Resolving PR comments
changelog: User-facing Improvements, In-person Proofing, Add warning banner to password reset email when the user has an in-progress in-person enrollment
* feat: remove skip_doc_auth from session * changelog: Internal, In-person proofing, remove old skip_doc_auth variable from session
changelog: Internal, Analytics, Remove unused event parameter from RedirectController
changelog: Internal, Error Logging, Exempt additional WebAuthn error logging as expected
* Stop writing to the proofing_components table Just stop. These values are now generated dynamically as we need them, then serialized to the Profile. [skip changelog] * Update LinkSentController spec * Update UspsLocationsController + spec I moved idv_session to be public on the controller (matching the behavior of other controllers that use IdvSessionConcern). Then updated tests to use dynamically-generated proofing components. This requires reloading the user object. I created https://cm-jira.usa.gov/browse/LG-15167 to address computing the proofing component value without using the User object * Move proofing_component check to end of end-to-end spec We don't have access to idv_session here so we have to wait until the proofing component has been written to the database so we can access it. * Remove proofing components from pw reset disavowal form spec We were clearing out the _user's_ proofing component here, but not doing anything with the profile. * Remove references to ProofingComponent from specs * Don't check proofing_component in ResolutionProofingJob * Remove ProofingComponent model
* changelog: Internal, Reporting, Optimize Query Adjust query and adjust for opted-in flows Co-authored-by: Mitchell Henke <[email protected]> Co-authored-by: Zach Margolis <[email protected]>
We are planning on sending additional attributes that we read off of documents to AAMVA. This commit modifies the AAMVA client to do so. The new attributes are: - Middle name - Name suffix - Sex - Height - Weight - Eye color These attributes are only sent if they are available in the applicant. For most of the attributes we do not currently read them from the document so they will not be sent until we enable the feature to do so. The exception to this is middle name. For that reason a feature flag controls whether we send middle name. We will log whether these attributes are sent and whether they are validated. None of these attributes are "required attributes" so a user will still pass if they are absent or if they do not match. changelog: Internal, AAMVA DLDV, Send additional attributes to AAMVA
…le (#11579) * do not require customer profile for idv_socure_verification_data_requested analytics event * [skip changelog]
mitchellhenke
approved these changes
Dec 3, 2024
mitchellhenke
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features