Exempt additional WebAuthn error logging as expected #11577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Error Logging, Exempt additional WebAuthn error logging as expected
matthinz
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates expected error logging conditions for WebAuthn errors to exclude a handful of additional error cases.
After further investigation, these errors are explainable by either known device / credential manager incompatibilities, or lack of support when verifying on a device other than the one that set up Face or Touch Unlock.
This follows #11481, which effectively fixed explicit frontend error logging, causing additional errors to be surfaced in NewRelic error logging.
Related Slack discussions:
📜 Testing Plan
This will be difficult to test in practice, since the errors surfaced here are edge cases on specific device types.