Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14985 Read additional document data from TrueID when configured to do so #11559

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

jmhooper
Copy link
Contributor

We are working to send additional data to AAMVA when it is present on documents. This commit lays groundwork for this by reading those new attributes from TrueID when configured to do so.

We are waiting on security approval before we start writing these new attributes into the Login.gov session. For that reason the reading of these attributes is feature flagged and disabled by default.

@jmhooper jmhooper requested a review from a team November 26, 2024 15:25
jmhooper added a commit that referenced this pull request Nov 26, 2024
In #11559 we will be reading new attributes from the document during document authentication. This commit updates the doc auth mock client to match this behavior. This will help us identify any issues these new attributes may cause in lower environments.

[skip changelog]
Base automatically changed from jmhooper-add-new-state-id-attributes to main November 26, 2024 17:10
jmhooper added a commit that referenced this pull request Nov 26, 2024
In #11559 we will be reading new attributes from the document during document authentication. This commit updates the doc auth mock client to match this behavior. This will help us identify any issues these new attributes may cause in lower environments.

[skip changelog]
@jmhooper jmhooper force-pushed the jmhooper-read-pii-from-true-id branch from c077ef1 to 3eccf93 Compare November 26, 2024 17:11
… do so

We are working to send additional data to AAMVA when it is present on documents. This commit lays groundwork for this by reading those new attributes when configured to do so.

We are waiting on security approval before we start writing these new attributes into the Login.gov session. For that reason the reading of these attributes is feature flagged and disabled by default.

changelog: Internal, Document Authentication, Read additional document data from TrueID when configured to do so
@jmhooper jmhooper force-pushed the jmhooper-read-pii-from-true-id branch from 3eccf93 to 1eca2d5 Compare November 26, 2024 17:11
Copy link
Contributor

@matthinz matthinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor spelling things here, but otherwise LGTM

jmhooper added a commit that referenced this pull request Nov 26, 2024
In #11559 we will be reading new attributes from the document during document authentication. This commit updates the doc auth mock client to match this behavior. This will help us identify any issues these new attributes may cause in lower environments.

[skip changelog]
@jmhooper jmhooper merged commit 8a60da4 into main Nov 26, 2024
2 checks passed
@jmhooper jmhooper deleted the jmhooper-read-pii-from-true-id branch November 26, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants