Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-13006: remove skip_doc_auth from session #11569

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

KeithNava
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-13006

🛠 Summary of changes

Removing the last use of the unused skip_doc_auth from the session

📜 Testing Plan

Since the use business logic using the older skip_doc_auth variable was already removed the automated tests should be enough.

@KeithNava KeithNava force-pushed the keithw/LG-13006-complete-removal-of-skip-doc-auth branch from a5fb895 to 46faedb Compare November 27, 2024 15:12
@KeithNava KeithNava requested review from a team and shanechesnutt-ft November 27, 2024 15:13
@KeithNava KeithNava marked this pull request as ready for review November 27, 2024 15:13
Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked that no skip_doc_auth references exist. Looks good to me! 👍🏻

Copy link
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a manual test and was able to verify via ID-IPP. I double-checked there are no remaining instances of skip_doc_auth. Good work. 👏🏻

@KeithNava KeithNava merged commit 92d2b2f into main Dec 2, 2024
2 checks passed
@KeithNava KeithNava deleted the keithw/LG-13006-complete-removal-of-skip-doc-auth branch December 2, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants