LG-13763: Stop writing to the proofing_components table #11564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just stop. These values are now generated dynamically as we need them, then serialized to the Profile. [skip changelog]
I moved idv_session to be public on the controller (matching the behavior of other controllers that use IdvSessionConcern). Then updated tests to use dynamically-generated proofing components. This requires reloading the user object. I created https://cm-jira.usa.gov/browse/LG-15167 to address computing the proofing component value without using the User object
We don't have access to idv_session here so we have to wait until the proofing component has been written to the database so we can access it.
We were clearing out the _user's_ proofing component here, but not doing anything with the profile.
n1zyy
reviewed
Nov 26, 2024
| user:, | ||
| ) | ||
|
|
||
| expect(proofing_components.document_check).to be_nil |
There was a problem hiding this comment.
I feel like I'm missing some context here. Is an equivalent to Idv::ProofingComponents.new happening in the controller?
There was a problem hiding this comment.
Idv::ProofingComponents reads info from sessions (Rails, user, and Idv::) to derive the current components. Previously the controller was updating the proofing_component attached to the user. Here we're just taking the various sessions the controller is interacting with and essentially checking that it made the changes we are expecting. You could make an argument that this test might be duplicative now (we should be testing that the controller is updating Idv::Session appropriately elsewhere)
|
This was previously blocked by #11527, which is now in prod. Sooooo.... |
matthinz
deleted the
matthinz/13763-proofing-components-stop-just-stop
branch
matthinz
added a commit
that referenced
this pull request
Dec 18, 2024
We missed this when we got rid of the ProofingComponent model in #11564 [skip changelog]
matthinz
added a commit
that referenced
this pull request
Dec 19, 2024
We missed this when we got rid of the ProofingComponent model in #11564 [skip changelog]
matthinz
added a commit
that referenced
this pull request
Dec 19, 2024
We missed this when we got rid of the ProofingComponent model in #11564 [skip changelog]
matthinz
added a commit
that referenced
this pull request
Jan 6, 2025
Since #11564 we've stopped writing to this table, so now is the time to drop it. This table was previously used as a temporary datastore for proofing component values as a user moves through IdV. We now dynamically derive those values from the Idv::Session, so this table is not needed any longer. [skip changelog]
1 task
matthinz
added a commit
that referenced
this pull request
Jan 7, 2025
* Drop proofing_components table Since #11564 we've stopped writing to this table, so now is the time to drop it. This table was previously used as a temporary datastore for proofing component values as a user moves through IdV. We now dynamically derive those values from the Idv::Session, so this table is not needed any longer. [skip changelog] * Update db/primary_migrate/20250106232958_drop_proofing_components_table.rb Co-authored-by: Zach Margolis <[email protected]> --------- Co-authored-by: Zach Margolis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13763
🛠 Summary of changes
ProofingComponentis a model that tracks, in general terms, how a user has verified their identity. It exists in a 1:1 relationship withUser, which gets kind of sticky / tricky for users with multiple Profiles.Proofing components are useful for logging purposes, so we want to keep them. But instead of storing them attached to
Userin this way, we are now dynamically deriving them from the user'sIdV::Session.So then, now that we are doing that, we can stop writing to the old user-bound
proofing_componentsstuff. That's what this PR does. We'll be dropping the table itself in a future PR.