Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Node 16.13 for CI builds #6154

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Specify Node 16.13 for CI builds #6154

merged 1 commit into from
Jun 14, 2022

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Jun 13, 2022

Builds have stopped working with Node 16.15.1. This specifies 16.13 as a short-term solution to get deploys working again.

Staging branch URL: https://pr-6154.pfe-preview.zooniverse.org

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

Builds have stopped working with Node 16.15.1. This specifies 16.13 as a short-term solution to get deploys working again.
@eatyourgreens eatyourgreens added the ops Changes that affect how something is built or deployed label Jun 13, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 50.172% when pulling 83cd37b on fix-node-builds into b35ff23 on master.

@eatyourgreens eatyourgreens merged commit e83dd4e into master Jun 14, 2022
@eatyourgreens eatyourgreens deleted the fix-node-builds branch June 14, 2022 14:40
@camallen camallen mentioned this pull request Sep 30, 2022
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority ops Changes that affect how something is built or deployed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants