Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest lts version of node #6203

Merged
merged 4 commits into from
Oct 3, 2022
Merged

use latest lts version of node #6203

merged 4 commits into from
Oct 3, 2022

Conversation

camallen
Copy link
Contributor

@camallen camallen commented Sep 30, 2022

why node is locked to minor version is strange...this leaves the system out of date. Perhaps there is a good reason for this... aha short term solution to get the builds running again #6154

This PR keeps the node major version but allows latest minor and patch versions to be tested against, https://github.com/actions/setup-node#supported-version-syntax

This will need to by synced with the deploy configs as well https://github.com/zooniverse/Panoptes-Front-End/search?q=node_version

looks like the deprecated modal-form is blocking the react bump to v17+ https://github.com/zooniverse/modal-form/blob/635652c42e797abc1c5843f5fcce98f646027505/package.json#L6

TBH - it's strange that this even works in node 16.3.x as the dependencies are borked...i assume an npm bug

Staging branch URL: https://pr-{NUMBER}.pfe-preview.zooniverse.org

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@camallen camallen requested a review from a team September 30, 2022 13:52
@coveralls
Copy link

coveralls commented Sep 30, 2022

Coverage Status

Coverage remained the same at 50.209% when pulling cad686b on bump-ci-to-lts-node into 07d7488 on master.

camallen and others added 4 commits October 3, 2022 14:44
Copy link
Contributor

@eatyourgreens eatyourgreens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is building and deploying without problems after editing .npmrc.

@eatyourgreens eatyourgreens merged commit 1748e27 into master Oct 3, 2022
@eatyourgreens eatyourgreens deleted the bump-ci-to-lts-node branch October 3, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants