Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why node is locked to minor version is strange...this leaves the system out of date. Perhaps there is a good reason for this...aha short term solution to get the builds running again #6154This PR keeps the node major version but allows latest minor and patch versions to be tested against, https://github.com/actions/setup-node#supported-version-syntax
This will need to by synced with the deploy configs as well https://github.com/zooniverse/Panoptes-Front-End/search?q=node_versionlooks like the deprecated
modal-form
is blocking the react bump to v17+ https://github.com/zooniverse/modal-form/blob/635652c42e797abc1c5843f5fcce98f646027505/package.json#L6TBH - it's strange that this even works in node 16.3.x as the dependencies are borked...i assume an npm bug
Staging branch URL: https://pr-{NUMBER}.pfe-preview.zooniverse.org
Required Manual Testing
Review Checklist
npm ci
and app works as expected?Optional
ChangeListener
orPromiseRenderer
components with code that updates component state?