Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script for production deploy action #6156

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented Jun 28, 2022

Staging branch URL: https://pr-6156.pfe-preview.zooniverse.org

Fixes https://github.com/zooniverse/Panoptes-Front-End/runs/7098696366?check_suite_focus=true.

Describe your changes.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@mcbouslog mcbouslog requested a review from eatyourgreens June 28, 2022 18:39
@mcbouslog mcbouslog self-assigned this Jun 28, 2022
@mcbouslog mcbouslog requested review from a team and removed request for eatyourgreens June 28, 2022 18:43
@coveralls
Copy link

coveralls commented Jun 28, 2022

Coverage Status

Coverage increased (+0.03%) to 50.197% when pulling 23e3cd3 on update-script-prod-action into 230cce8 on master.

Copy link
Contributor

@goplayoutside3 goplayoutside3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mcbouslog mcbouslog merged commit 091c383 into master Jun 29, 2022
@mcbouslog mcbouslog deleted the update-script-prod-action branch June 29, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants