-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reroll #1816 into a new PR + fix for test failures #2384
Conversation
Not sure if it's related to the tests or not, but I've the same issue as this after running |
@gaving, that is a neat way to install yarn from a PR! Does the issue with |
Thanks @chrisirhc and @f-sign, I merged without squashing |
@bestander Ahh good point, tried with another PR and master even and got the same error. Sorry for the noise, looking forward to a release! |
I'm still running into another issue even after building from master or using the latest nightly build ( $ yarn install
yarn install v0.19.0-20170106.1725
info No lockfile found.
[1/4] 🔍 Resolving packages...
error Command failed.
Exit code: 128
Command: git
Arguments: clone ssh://[email protected]:githubuser/repo.git /Users/username/Library/Caches/Yarn/.tmp/bff4d24c292f2c5f1a876330de56ef81
Directory: /Users/username/project
Output:
Cloning into '/Users/username/Library/Caches/Yarn/.tmp/bff4d24c292f2c5f1a876330de56ef81'...
ssh: Could not resolve hostname github.com:githubuser: nodename nor servname provided, or not known
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
$ git clone [email protected]:githubuser/repo.git # Just a sanity check
Cloning into 'repo'...
remote: Counting objects: 35, done.
remote: Total 35 (delta 0), reused 0 (delta 0), pack-reused 35
Receiving objects: 100% (35/35), 9.79 KiB | 0 bytes/s, done.
Resolving deltas: 100% (10/10), done. It appears to be trying to incorrectly clone with the Doing some minimal debugging so far, it looks like it's going through the For completeness, here's the dependency string in my |
Replicating @sudowork's behaviour after a |
Actually after revisiting this comment, things now appear to work for me (didn't before). Trick is to change URL format:-
to
Not sure if the semicolon version is supposed to work after this PR, but I'm just happy something is working now. 😄 Full example:-
|
@gaving, Based on the tests, I believe that using the colon separator is supposed to be working. 477c612#diff-00109fff57c65d5eba87e219e6d5a825R44 I may look into why it's not a bit more over the weekend. |
Closes yarnpkg#573, closes yarnpkg#2416. Related to yarnpkg#2384, yarnpkg#573.
Closes yarnpkg#573, closes yarnpkg#2416. Related to yarnpkg#2384, yarnpkg#573.
Closes yarnpkg#573, closes yarnpkg#2416. Related to yarnpkg#2384, yarnpkg#573.
* Fix private urls using colon separator Closes yarnpkg#573, closes yarnpkg#2416. Related to yarnpkg#2384, yarnpkg#573. * Remove unused suppression * Move to dedicated method & add tests
So how are you supposed to use yarn with SSH, it seems clear as mud and if possible more hacky than with npm? |
Summary
Intended to solve #573 . This is a re-application of the changes in #1816 but with a fix for the tests in 3c55f6b. All work is credited to @f-sign . Only attempting to re-run tests and clean up the PR so it doesn't have duplicate commits from master.
Test plan
Tests pass. Left it up to author of #1816 .
Background
This originated from investigating #1816 (comment) .