Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git+ssh installs fail with GitHub URLs with colon separators #2416

Closed
epmatsw opened this issue Jan 9, 2017 · 1 comment
Closed

git+ssh installs fail with GitHub URLs with colon separators #2416

epmatsw opened this issue Jan 9, 2017 · 1 comment

Comments

@epmatsw
Copy link

epmatsw commented Jan 9, 2017

Do you want to request a feature or report a bug?

Bug

What is the current behavior?
When installing from a git url (after having the fix in #2384), the install fails with:

yarn install v0.19.0-20170106.1725
info No lockfile found.
[1/4] 🔍  Resolving packages...
error Command failed.
Exit code: 128
Command: git
Arguments: clone ssh://[email protected]:githubuser/repo.git /Users/username/Library/Caches/Yarn/.tmp/bff4d24c292f2c5f1a876330de56ef81
Directory: /Users/username/project
Output:
Cloning into '/Users/username/Library/Caches/Yarn/.tmp/bff4d24c292f2c5f1a876330de56ef81'...
ssh: Could not resolve hostname github.com:githubuser: nodename nor servname provided, or not known
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

If the current behavior is a bug, please provide the steps to reproduce.

It appears that any git url that uses : rather than / for the separator between the url and github user/org still fails even with the fix.

See comments in #2384 1 2 3

What is the expected behavior?
The install succeeds without errors.

Please mention your node.js, yarn and operating system version.
Node 7.4.0, yarn 0.19.0, macOS 10.12.2

@chrisirhc
Copy link
Contributor

Related to #573 (comment) . Seems that a custom resolver needs to be set up to handle the : behavior.

balthazar pushed a commit to balthazar/yarn that referenced this issue Jan 20, 2017
balthazar pushed a commit to balthazar/yarn that referenced this issue Jan 26, 2017
balthazar pushed a commit to balthazar/yarn that referenced this issue Jan 26, 2017
mnsn pushed a commit to mnsn/yarn that referenced this issue Feb 15, 2017
* Fix private urls using colon separator

Closes yarnpkg#573, closes yarnpkg#2416.

Related to yarnpkg#2384, yarnpkg#573.

* Remove unused suppression

* Move to dedicated method & add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants