Fix private urls using colon separator #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The might not work for some git urls since |
balthazar
force-pushed
the
fix-private-url
branch
from
7efb32a to
28835f4
Compare
Closes yarnpkg#573, closes yarnpkg#2416. Related to yarnpkg#2384, yarnpkg#573.
balthazar
force-pushed
the
fix-private-url
branch
from
e1d091e to
4daef28
Compare
btford
reviewed
Feb 3, 2017
|
|
||
| }); | ||
|
|
||
| test('GitResolver transformUrl affect host colon separated urls', () => { |
There was a problem hiding this comment.
Maybe call this 'GitResolver transformUrl replaces the colon on colon separated urls' ?
| // This transformUrl util is here to replace colon separators in the pathname | ||
| // from private urls. It takes the url parts retrieved using urlFormat and | ||
| // returns the associated url. Related to #573, introduced in #2519. | ||
| static transformUrl(parts) : string { |
There was a problem hiding this comment.
I think we can probably come up with a more descriptive name than "transform."
|
Nice work, thanks a lot for the tests! |
mnsn
pushed a commit
to mnsn/yarn
that referenced
this pull request
Feb 15, 2017
* Fix private urls using colon separator Closes yarnpkg#573, closes yarnpkg#2416. Related to yarnpkg#2384, yarnpkg#573. * Remove unused suppression * Move to dedicated method & add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People were still experiencing issues with private urls using colons as separator even after the fix introduced in #2384.
This fix basically replace the initial pathname part of the parsed url in the git resolver, and reformat exploded parts onto the equivalent url, removing the colon culprit.
Unsure about why the require onto the
urlmodule is done the old way, I've decided to follow consistency, but can refactor if needed. Related issues referenced in commit.👋 @chrisirhc @lxe