Fix issue #573 - private git ssh urls #1816
Conversation
|
@wyze the CI seems to have failed due to missing public keys - can you re-run? |
|
@BryanCrotaz, they are rerunning now. |
|
@wyze it seems like CI failed again due to key errors installing from GitHub |
|
Any chance someone with the permissions can re-run the tests? |
|
Kicked off a rebuild on Travis. |
|
@wyze Failed again with |
|
Other builds are passing. This PR touches the |
|
@wyze it's not getting as far as running the tests: The PR doesn't touch the package.json so I can't see how this PR would break it |
|
@wyze DOH!!!! I'm an idiot. Ignore that last message. I'll ask Flavio to take another look. |
|
Any updates on why the CI tests are failing? |
|
@f-sign and I have been looking at it - can't work out how taking some comments out has caused the build to fail |
…itten (yarnpkg#1970) * Fix for yarnpkg#1214 Scoped dependencies are nested one folder deeper than traditional dependencies, the possiblyExtraneous needed updating to work with the actual dependencies, not the entire scoped folder. * Fix typo/variable renaming
* Use isRootUser function instead USER environment variable * Fix yarnpkg#2123
* Add failing tests for bin path normalisation from scoped package name * Add fix for bin normalisation for scoped packages
|
@BryanCrotaz, any updates on this? What's the plan? |
|
Sorry for the delay... Some deadlines here. We've run the tests locally against latest master and our PR branch. We get the same 3 failures on both: MASTER eb66b9c Mine 9780017 The first time I submitted the pull request it passed all tests and I was asked to remove some commented out console.log(). After removing then, it is not passing one of the tests. I am running the tests on Windows. |
…npkg#2063) - Only look for mandetory files (`package.json`, `readme`, `license`, etc) in root - Stop `fs.walk` inside ignored dirs (`node_modules`, `.git`, `.svn`, etc), makes `pack` way faster
* Add support for disabling progress bar * after config is initialized, check global yarn config for disableProgress * Add utility function to disable progress on base-reporter * Add base reporter disableProgress test
|
On macOS 10.12.2, node 7.2.0, and npm 3.10.9, I had one run that had a single failure (something about |
The original test asserts that window cmd line formatting is properly applied or not applied, for only the target platform the tests are executed on - that will have to be good enough. It is not possible to test both branches from one platform because the path module employed in the test alters its export based on process.platform in Node bootstrap, well before one can mock it.
|
@wyze any idea why we're all getting different sets of test failures with the same source? |
* updated tests caches * updated hash in test
|
I'm desperate for this functionality so tried installing this pull with:-
But just ended up with the same error @epmatsw has posted:- |
|
@gaving I also tried pulling as well and got that error at first, but if you manually run |
|
@wyze any clues as to what we can fix to get this merged? |
* Silly fix: Node on Ubuntu on Windows crashes when there is a for-of loop followed by an exception * Run global install script only on CI because it modifies user's environment * fixed tests setup when fixture location was not set - it would copy full folder otherwise * Revert "Silly fix: Node on Ubuntu on Windows crashes when there is a for-of loop followed by an exception" This reverts commit 68179d0. * cleaned up herlper logic when fixture name is not passed * refactored test: Unhandled promise warning * fixed lint error * fixed lint error * fixed lint error * fixed lint error * moved temp folder creation to an fs function and added a bit to omit folder name collisions
* Adds inquirer libdefs for more exact typings * Refine / Fix some flowtype errors (mostly in __tests__) * Fix a small bug in src/util/map.js found by [email protected]
* rename cmd link to cmd shim from .cmd.cmd to .cmd * use !== instead of !=
|
Looks like the error is centered around: Does this change make it so that previous behavior that did: This would be difficult to reproduce locally because most folks that cloned this project would have configured their SSH keys with github.com and the tests would be successful locally because of that. |
|
Looked into the above issue and it originates from 477c612#diff-5d246f90b159bd84bbc99f67527b1a0eR373 . The change in Rolled the fix into #2384 along with cleaning up the rebase. This should resolve the test failures we're seeing here. Though it seems the tests are still somewhat flaky. |
|
This one got a bad rebase, merged via #2384. |
Summary
Yarn didn't support certain formats of git urls, especially the ones with colon on it.
Test plan
Added tests to reproduce the problem and these tests all pass.