Upgrade to [email protected] / fix some typings #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bestander What is happening with CI right now? Any open issue tackling this problem? Seems that several tests are failing due to some changes |
|
@ryyppy, I fixed this, could you rebase please? |
* Adds inquirer libdefs for more exact typings * Refine / Fix some flowtype errors (mostly in __tests__) * Fix a small bug in src/util/map.js found by [email protected]
|
@bestander Hmm, not sure what's happening here on CircleCI:
|
bestander
reviewed
Jan 3, 2017
| @@ -16,6 +16,7 @@ | |||
| "defaults": "^1.0.3", | |||
| "detect-indent": "^4.0.0", | |||
| "diff": "^2.2.1", | |||
| "flow-bin": "^0.37.3", | |||
There was a problem hiding this comment.
That is the reason why Circle failed.
I'll send a quick fix
bestander
added a commit
to bestander/yarn
that referenced
this pull request
Jan 3, 2017
|
Awesome, thanks 👍 |
bestander
added a commit
that referenced
this pull request
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__tests__)src/util/map.jsfound by [email protected]Summary
This PR adds flow-typed definitions for
inquirer. Nice thing is, I didn't even need to touch the code after adding the definitions (I played around with it and could produce errors when passing wrong parameters toinquirer.prompt()).Also I invested some time to upgrade
flowfrom0.33to the most recent version0.37.3, fixing some typing issues / bugs along the way.Test plan
When I originally pulled the source from
master, I realized that 11 tests were failing.So I was doing two test runs, one testing the HEAD and one testing my modifications.
The same number of tests failed.
Also I made sure that
[email protected]type checks the source properly.