Apply the network-concurrency option to the package fetchers #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bestander Would it be ok to merge this as a fix for #2129, it seems that without this change the other merge is not effective. Thanks! |
albertfdp
added a commit
to albertfdp/yarn
that referenced
this pull request
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up from #2129 where the network concurrency was not being passed down to the package fetcher, so the problem was not fixed in that scenario.
Test plan
Running
yarn install --concurrency 1on https://github.com/albertfdp/yarn-github-repos should not raise a Connection reset by peer error.