Add support to max network concurrent requests #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertfdp
force-pushed
the
network-concurrency
branch
from
7ae0a49 to
f38d9aa
Compare
bestander
requested changes
Dec 4, 2016
| @@ -202,6 +203,7 @@ export default class Config { | |||
| cafile: String(opts.cafile || this.getOption('cafile') || ''), | |||
| cert: String(opts.cert || this.getOption('cert') || ''), | |||
| key: String(opts.key || this.getOption('key') || ''), | |||
| concurrency: Number(opts.concurrency || this.getOption('concurrency') || constants.NETWORK_CONCURRENCY), | |||
There was a problem hiding this comment.
we also have child concurrency, I think this option should be more specific to avoid confusion what kind of concurrency it is
There was a problem hiding this comment.
Thanks! I've renamed it to network-concurrency, hope this is more specifc
albertfdp
force-pushed
the
network-concurrency
branch
2 times, most recently
from
427ea8e to
6d1ff61
Compare
albertfdp
force-pushed
the
network-concurrency
branch
from
6d1ff61 to
540c293
Compare
albertfdp
added a commit
to albertfdp/yarn
that referenced
this pull request
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In my organization we are consuming many private dependencies as GitHub private repositories through ssh (i.e.
git+ssh://[email protected]/org/name.git), which results that when the number of these dependencies exceeds some limit (around 10), the number of concurrent requests to GitHub from the same IP will result in aConnection reset by peer errorwhich is a DoS protection from GitHub.Fixes #1307
Since yarn will cache all successful fetches, it really does not matter that the first fetch of dependencies is a bit slow.
Let me know if
concurrencyis also the proper name, I'm thinking if I should usenetwork-concurrencyinstead?Test plan
Running
yarn install --concurrency 1on https://github.com/albertfdp/yarn-github-repos should not raise aConnection reset by peererror.I've been looking into the tests at https://github.com/yarnpkg/yarn/blob/master/__tests__/util/request-manager.js but I'm not sure how to add a test to verify the concurrency. I'd be very happy to add a unit test if I can get some guidance.