This repository has been archived by the owner on Mar 4, 2019. It is now read-only.
Feat: Create Slider/Multislider component #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
force-pushed
the
feat/multislider
branch
2 times, most recently
from
17687d1 to
ec26452
Compare
lukewalczak
changed the title
lukewalczak
force-pushed
the
feat/multislider
branch
from
ec26452 to
ce3abfe
Compare
RobinCsl
reviewed
Jan 9, 2019
RobinCsl
reviewed
Jan 9, 2019
JosefDuda
reviewed
Jan 9, 2019
lukewalczak
force-pushed
the
feat/multislider
branch
2 times, most recently
from
e22824d to
393b6cf
Compare
|
Deploy preview for kiwicom-universal-components ready! Built with commit 0a1ef42 https://deploy-preview-184--kiwicom-universal-components.netlify.com |
lukewalczak
force-pushed
the
feat/multislider
branch
from
393b6cf to
9cb8413
Compare
JosefDuda
reviewed
Jan 9, 2019
JosefDuda
reviewed
Jan 9, 2019
src/Slider/Slider.js
Outdated
| return (value * width) / (maxValue - minValue) - LABEL_LENGTH / 2; | ||
| }; | ||
|
|
||
| createParts = () => { |
There was a problem hiding this comment.
What about extracting this part into some separate TrackLine component? Maybe even with those current two Views with trackLine style.
|
There is currently some short ugly jump in web version during initialisation. It will be nice to take care of it somehow or at least show component after everything is set. But it probably doesn't need to be solved right now and we can create separate issue for this improvement. Otherwise awesome work! |
lukewalczak
force-pushed
the
feat/multislider
branch
from
dfd532d to
c6af82f
Compare
lukewalczak
force-pushed
the
feat/multislider
branch
from
c6af82f to
8314236
Compare
JosefDuda
reviewed
Jan 10, 2019
lukewalczak
force-pushed
the
feat/multislider
branch
from
8314236 to
029d5d6
Compare
That PR will add slider/multislider component
lukewalczak
force-pushed
the
feat/multislider
branch
4 times, most recently
from
44aab0a to
c7f87dd
Compare
lukewalczak
force-pushed
the
feat/multislider
branch
2 times, most recently
from
32f5bbd to
6109b2a
Compare
lukewalczak
force-pushed
the
feat/multislider
branch
from
6109b2a to
10c1607
Compare
RobinCsl
reviewed
Jan 10, 2019
Summary: Luke Walczak from CallStack had to fork react-native-multi-slider and add changes to match our requirements; there now is a fork on kiwicom org and his changes were merged in it.
lukewalczak
force-pushed
the
feat/multislider
branch
from
27c1797 to
6c4440b
Compare
RobinCsl
reviewed
Jan 11, 2019
Summary: This will make sure any changes to master on https://github.com/kiwicom/react-native-multi-slider.git will not unintentionally come into this code base. Removed unnecessary rule in .storybook/webpack.config.js related to `react-native-multi-slider`.
RobinCsl
force-pushed
the
feat/multislider
branch
from
f96020e to
0a1ef42
Compare
RobinCsl
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR will add slider/multislider component
Fixes: #103