Switched default LIMS driver in samplesheet generation #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched the default LIMS driver in samplesheet generation from 'xml' to 'ml_warehouse'. Added 'lims_driver_type' attribute to npg::samplesheet. Updated the tests for samplesheet generation, which are using the xml LIMS driver, to set the driver type explicitly.
mgcam
force-pushed
the
change_default_lims_driver4samplesheet
branch
from
7adf249 to
626bd65
Compare
jmtcsngr
reviewed
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the default LIMS driver in samplesheet generation from 'xml' to 'ml_warehouse'.
Added 'lims_driver_type' attribute to npg::samplesheet. Updated the tests for samplesheet generation, which are using the xml LIMS driver, to set the driver type explicitly.