Drop xml fixtures in tests for samplesheet generation #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgcam
force-pushed
the
drop_xml_fixtures4samplesheet
branch
5 times, most recently
from
d70ecf3 to
be6cd44
Compare
Previously the tests uses XML feeds as a source of LIMS data. All production code is using mlwh database as a source of LIMS data. Amend tests to use mlwh data and the default ml_warehouse lims driver. Amended how an undefined sample public name is dealt with, i.e. converted an error to a warning and assigned a sensible fall-back value. Some samplesheets are generated without names of study owners, followers, etc. This is due to the fact that some studies do not have fixtures for user data. The database fixtures were generated from the current data, this explains multiple differences between the old and new content of the generated samplesheets. In some tests newer production batches were used instead of hand-crafted data. Deleted tests for old scenarios that do not exist in production any longer. Deleted tests that are duplicated by similar tests with more contemporary test data.
mgcam
force-pushed
the
drop_xml_fixtures4samplesheet
branch
from
be6cd44 to
02c083d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tests uses XML feeds as a source of LIMS
data. All production code is using mlwh database as a
source of LIMS data. Amend tests to use mlwh data and
the default ml_warehouse lims driver.
Amended how an undefined sample public name is dealt with,
i.e. converted an error to a warning and assigned a sensible
fall-back value.
Some samplesheets are generated without names of study owners,
followers, etc. This is due to the fact that some studies
do not have fixtures for user data.
The database fixtures were generated from the current data,
this explains multiple differences between the old and new
content of the generated samplesheets.
In some tests newer production batches were used instead of
hand-crafted data.
Deleted tests for old scenarios that do not exist in production
any longer.
Deleted tests that are duplicated by similar tests with more
contemporary test data.