-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 4] Style iFrame #9
Conversation
Once again, nice work @websupporter This is definitely better. The input text is now larger and easier to read: https://d.pr/i/QcZg7o This size is in line with some of our other payment gateways, so I am happy to settle with this. That said, since we are taking the approach of copying the styles from another form element, I thought we could get even closer by instead copying from one of the input elements from within the billing details form itself. For example, passing the first name input field ( What are your thoughts? |
I did chose the card number field for input as this is the one, which gets rendered by the CC_Gateway and themes can/could specifically target it. storefront is actually an example of it: |
Ah. Thanks for clarifying! In that case, this LGTM. Merging. |
applies the styles of the original DCC input field to the DCC input field inside the PayPal iFrame as much as possible. See #4 (comment) about some of the shortcomings.
Related #4
Fixes #18