Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 4] Style iFrame #9

Merged
merged 3 commits into from
Sep 24, 2020
Merged

[Issue 4] Style iFrame #9

merged 3 commits into from
Sep 24, 2020

Conversation

websupporter
Copy link
Member

@websupporter websupporter commented Sep 18, 2020

applies the styles of the original DCC input field to the DCC input field inside the PayPal iFrame as much as possible. See #4 (comment) about some of the shortcomings.

Related #4
Fixes #18

@chickenn00dle chickenn00dle self-assigned this Sep 23, 2020
@chickenn00dle
Copy link
Contributor

Once again, nice work @websupporter

This is definitely better. The input text is now larger and easier to read: https://d.pr/i/QcZg7o

This size is in line with some of our other payment gateways, so I am happy to settle with this.

That said, since we are taking the approach of copying the styles from another form element, I thought we could get even closer by instead copying from one of the input elements from within the billing details form itself. For example, passing the first name input field ( document.querySelector( '#billing_first_name' ) ) to window.getComputedStyle() when setting stylesRaw, the text looks like this: https://d.pr/i/O1IJMZ

What are your thoughts?

@websupporter
Copy link
Member Author

I did chose the card number field for input as this is the one, which gets rendered by the CC_Gateway and themes can/could specifically target it. storefront is actually an example of it:
https://github.com/woocommerce/storefront/blob/745e1741fbc1120fc983f870cacc6b87580eea22/assets/css/woocommerce/woocommerce.scss#L1311-L1315

@jorgeatorres jorgeatorres added this to the 1.0 milestone Sep 23, 2020
@chickenn00dle
Copy link
Contributor

Ah. Thanks for clarifying! In that case, this LGTM. Merging.

@chickenn00dle chickenn00dle merged commit 709e54d into master Sep 24, 2020
@websupporter websupporter deleted the issue-4-style-iframe branch September 25, 2020 11:14
@phantasiali phantasiali mentioned this pull request Aug 28, 2023
@Lerie82 Lerie82 mentioned this pull request Feb 24, 2024
This was referenced Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font size for Card Processing form is inconsistent
3 participants