Update mention about dynamically generated slot names #6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sarah11918
reviewed
Jan 17, 2024
sarah11918
reviewed
Jan 17, 2024
There was a problem hiding this comment.
@MoustaphaDev Let me know if you're OK with the proposed changes below, or fix if necessary.
If it's for tomorrow's minor release, I'll take responsibility for merging it, along with the other docs!
sarah11918
added
improve documentation
Co-authored-by: Sarah Rainsberger <[email protected]>
MoustaphaDev
commented
Jan 18, 2024
|
I said I would add an example, but I think it's okay to keep it as-is, for now at least. |
|
Sounds perfect, thank you @MoustaphaDev ! NWTWWHB! |
sarah11918
added
merge-on-release
yanthomasdev
added a commit
that referenced
this pull request
Jan 25, 2024
* Update with PR #6440 * Update with PR #6386 * Up with PR #6532 * Up with PR #6436 * Upd Just for Lunaria with PR #6444 * Up with PR #6402 * Up with PR #6548 * Up with PR #6430 * Up with PR #6469 * Up with PR #6522 * Up with PR #6272 * Update src/content/docs/fr/editor-setup.mdx Co-authored-by: Thomas Bonnet <[email protected]> * Update src/content/docs/fr/reference/publish-to-npm.mdx Co-authored-by: Thomas Bonnet <[email protected]> --------- Co-authored-by: Thomas Bonnet <[email protected]> Co-authored-by: Yan Thomas <[email protected]>
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Sarah Rainsberger <[email protected]>
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Update with PR #6440 * Update with PR #6386 * Up with PR #6532 * Up with PR #6436 * Upd Just for Lunaria with PR #6444 * Up with PR #6402 * Up with PR #6548 * Up with PR #6430 * Up with PR #6469 * Up with PR #6522 * Up with PR #6272 * Update src/content/docs/fr/editor-setup.mdx Co-authored-by: Thomas Bonnet <[email protected]> * Update src/content/docs/fr/reference/publish-to-npm.mdx Co-authored-by: Thomas Bonnet <[email protected]> --------- Co-authored-by: Thomas Bonnet <[email protected]> Co-authored-by: Yan Thomas <[email protected]>
MoustaphaDev
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit 86ac9ba.
MoustaphaDev
added a commit
that referenced
this pull request
Feb 6, 2024
#6793) * Revert "Update mention about dynamically generated slot names (#6440)" This reverts commit 86ac9ba. * apply sarah's suggestions Co-authored-by: Sarah Rainsberger <[email protected]> --------- Co-authored-by: Sarah Rainsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In withastro/compiler#933, we added support for dynamically generated slots. This PR updates a reference about that feature not being supported and underlines the minimum astro version required to use it
For Astro version:
4.2.0.See astro PR withastro/astro#9605