Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update add-content-collections.mdx #6272

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Update add-content-collections.mdx #6272

merged 4 commits into from
Jan 17, 2024

Conversation

eko24ive
Copy link
Contributor

Description

Updated tutorial with information about potential TS-related issue in the context of tutorial and provided solution on how to resolve it. Please refer to #6271 for more information

Related issues & labels (optional)

@eko24ive
Update add-content-collections.mdx
f8ca382 
Updated tutorial with information about potential TS related issue in the context of tutorial and provided  solution on how to resolve it
@vercel Vercel
Copy link

vercel bot commented Jan 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 17, 2024 9:12pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 9:12pm

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@eko24ive
Copy link
Contributor Author

eko24ive commented Jan 11, 2024 •
edited
Loading

Self-reviewed my changes on the deployed preview on Netlify - looks good to me, but I can't shake the feeling that formatting may be improved somehow. I would appreciate if someone could point me in the right direction

@VoxelMC
Copy link
Contributor

VoxelMC commented Jan 14, 2024

Hello! Thank you for bringing this up!

I am not sure if a numbered step is the right way to go for this addition.
@sarah11918, would such an addition constitute a :::tip?

sarah11918
sarah11918 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience, @eko24ive ! We really appreciate you taking the time to add this helpful step to the tutorial, and are pleased to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jan 17, 2024
@vercel vercel bot temporarily deployed to Preview – docs January 17, 2024 20:51 Inactive
@sarah11918 sarah11918 merged commit 7b505c3 into withastro:main Jan 17, 2024
8 checks passed
@eko24ive
Copy link
Contributor Author

Glad to be of help! Apologies for messing step number sequence - it totally slipped my mind 😅

@liruifengv liruifengv mentioned this pull request Jan 18, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Jan 20, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jan 25, 2024
@McFlyPartages @thomasbnt @yanthomasdev
i18n(fr): Update translation for all outdated files (#6616)
7405875 
* Update with PR #6440

* Update with PR #6386

* Up with PR #6532

* Up with PR #6436

* Upd Just for Lunaria with PR #6444

* Up with PR #6402

* Up with PR #6548

* Up with PR #6430

* Up with PR #6469

* Up with PR #6522

* Up with PR #6272

* Update src/content/docs/fr/editor-setup.mdx

Co-authored-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/reference/publish-to-npm.mdx

Co-authored-by: Thomas Bonnet <[email protected]>

---------

Co-authored-by: Thomas Bonnet <[email protected]>
Co-authored-by: Yan Thomas <[email protected]>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@eko24ive @VoxelMC
@sarah11918 @ematipico
Update add-content-collections.mdx (#6272)
ed9aa61 
Co-authored-by: voxel!() <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@McFlyPartages @thomasbnt
@yanthomasdev @ematipico
i18n(fr): Update translation for all outdated files (#6616)
97375e3 
* Update with PR #6440

* Update with PR #6386

* Up with PR #6532

* Up with PR #6436

* Upd Just for Lunaria with PR #6444

* Up with PR #6402

* Up with PR #6548

* Up with PR #6430

* Up with PR #6469

* Up with PR #6522

* Up with PR #6272

* Update src/content/docs/fr/editor-setup.mdx

Co-authored-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/reference/publish-to-npm.mdx

Co-authored-by: Thomas Bonnet <[email protected]>

---------

Co-authored-by: Thomas Bonnet <[email protected]>
Co-authored-by: Yan Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠️ Issue while following tutorial page "Tutorial - Extend with Content Collections"
4 participants
@eko24ive @astrobot-houston @VoxelMC @sarah11918