Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update mention about dynamically generated slot names (#6440)" #6793

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Feb 6, 2024

Description (required)

We're temporarily rolling back a feature (dynamically generated slots) which we added docs for in #6440, so I removed its mention in the docs

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 6, 2024 2:37pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Feb 6, 2024 2:37pm

@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Feb 6, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for not blowing up people's sites! 🫡

src/content/docs/en/basics/astro-components.mdx Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <[email protected]>
@MoustaphaDev MoustaphaDev merged commit 539b596 into main Feb 6, 2024
7 checks passed
@MoustaphaDev MoustaphaDev deleted the revert-dyn-slot-docs branch February 6, 2024 14:41
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Sep 21, 2024
* Use `props` with feminine form (`une propriété`)
* Replace singular `prop` with `property`
* Reword some sentences/Fix typo
* Use French quotes
* Add missing changes from withastro#6793 and withastro#5712
yanthomasdev added a commit that referenced this pull request Sep 23, 2024
… translation (#9463)

* i18n(fr): update `basics/astro-components.mdx`

* Use `props` with feminine form (`une propriété`)
* Replace singular `prop` with `property`
* Reword some sentences/Fix typo
* Use French quotes
* Add missing changes from #6793 and #5712

* i18n(fr): update `guides/cms/apostrophecms.mdx`

* Make usage of `props`/`property` consistent
* Fix some typo
* Translate in French an untranslated part

* i18n(fr): make usage of props/prop consistent

* fix anchor link in `typescript.mdx`

---------

Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants