-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update mention about dynamically generated slot names (#6440)" #6793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 86ac9ba.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sarah11918
added
the
improve documentation
Enhance existing documentation (e.g. add an example, improve description)
label
Feb 6, 2024
sarah11918
reviewed
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for not blowing up people's sites! 🫡
Co-authored-by: Sarah Rainsberger <[email protected]>
This was referenced Feb 6, 2024
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Sep 21, 2024
* Use `props` with feminine form (`une propriété`) * Replace singular `prop` with `property` * Reword some sentences/Fix typo * Use French quotes * Add missing changes from withastro#6793 and withastro#5712
yanthomasdev
added a commit
that referenced
this pull request
Sep 23, 2024
… translation (#9463) * i18n(fr): update `basics/astro-components.mdx` * Use `props` with feminine form (`une propriété`) * Replace singular `prop` with `property` * Reword some sentences/Fix typo * Use French quotes * Add missing changes from #6793 and #5712 * i18n(fr): update `guides/cms/apostrophecms.mdx` * Make usage of `props`/`property` consistent * Fix some typo * Translate in French an untranslated part * i18n(fr): make usage of props/prop consistent * fix anchor link in `typescript.mdx` --------- Co-authored-by: Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improve documentation
Enhance existing documentation (e.g. add an example, improve description)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
We're temporarily rolling back a feature (dynamically generated slots) which we added docs for in #6440, so I removed its mention in the docs