fix(compiler): Support dynamic slot names #9605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7ec190d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
MoustaphaDev
force-pushed
the
feat/dynamic-slot-names
branch
from
70c1d77 to
04939ac
Compare
…ynamic-slot-names
We were expecting the source code to produce an error, but in 2.4.0 of the compiler, that generates valid code
MoustaphaDev
commented
Jan 12, 2024
MoustaphaDev
changed the title
MoustaphaDev
changed the title
Merged
1 task
1 task
MoustaphaDev
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit 8ce40a4.
Princesseuh
added a commit
that referenced
this pull request
Feb 6, 2024
* Revert "fix(compiler): Support dynamic slot names (#9605)" This reverts commit 8ce40a4. * chore: changeset * Update .changeset/weak-pans-sit.md * chore: bump compiler version * fix failing test We were expecting the source code to produce an error, but in 2.4.0 of the compiler, that generates valid code --------- Co-authored-by: Erika <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
mergeSlotsfunction to the new approachPreviously, using variables as slot names within loops was not possible because of limitations in the compiler.
Those limitations were addressed and resolved in the linked compiler PR
Testing
forand amaploops to generate slot with dynamic namesDocs
I'll make a docs PR as this wasn't possible before