Revert "fix(compiler): Support dynamic slot names (#9605)" (#9999)

* Revert "fix(compiler): Support dynamic slot names (#9605)"

This reverts commit 8ce40a4.

* chore: changeset

* Update .changeset/weak-pans-sit.md

* chore: bump compiler version

* fix failing test

We were expecting the source code to produce an error, but in
2.4.0 of the compiler, that generates valid code

---------

Co-authored-by: Erika <[email protected]>

.changeset/weak-pans-sit.md

@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Rollbacks the feature which allowed to dynamically generate slots with variable slot names due to unexpected regressions.

packages/astro/package.json

@@ -114,7 +114,7 @@
     "test:e2e:match": "playwright test -g"
   },
   "dependencies": {
-    "@astrojs/compiler": "^2.5.0",
+    "@astrojs/compiler": "^2.5.3",
     "@astrojs/internal-helpers": "workspace:*",
     "@astrojs/markdown-remark": "workspace:*",
     "@astrojs/telemetry": "workspace:*",

packages/astro/src/runtime/server/index.ts

@@ -45,11 +45,8 @@ import { addAttribute, Renderer } from './render/index.js';
 
 export function mergeSlots(...slotted: unknown[]) {
 	const slots: Record<string, () => any> = {};
-	for (let slot of slotted) {
+	for (const slot of slotted) {
 		if (!slot) continue;
-		if (Array.isArray(slot)) {
-			slot = mergeSlots(...slot);
-		}
 		if (typeof slot === 'object') {
 			Object.assign(slots, slot);
 		} else if (typeof slot === 'function') {

packages/astro/test/astro-slots.test.js

@@ -30,26 +30,6 @@ describe('Slots', () => {
 		expect($('#default').text().trim()).to.equal('Default');
 	});
 
-	it('Dynamic named slots work with map work', async () => {
-		const html = await fixture.readFile('/dynamic-map/index.html');
-		const $ = cheerio.load(html);
-
-		expect($('#a').text().trim()).to.equal('A');
-		expect($('#b').text().trim()).to.equal('B');
-		expect($('#c').text().trim()).to.equal('C');
-		expect($('#default').text().trim()).to.equal('Default');
-	});
-
-	it('Dynamic named slots work with for loop', async () => {
-		const html = await fixture.readFile('/dynamic-for/index.html');
-		const $ = cheerio.load(html);
-
-		expect($('#a').text().trim()).to.equal('A');
-		expect($('#b').text().trim()).to.equal('B');
-		expect($('#c').text().trim()).to.equal('C');
-		expect($('#default').text().trim()).to.equal('Default');
-	});
-
 	it('Conditional named slots work', async () => {
 		const html = await fixture.readFile('/conditional/index.html');
 		const $ = cheerio.load(html);