-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slots appear to be broken in components rendered within a .map method #959
Comments
why router refreshing page ? |
I am sorry I don't think I quite understand your comment. |
Did reverting the compiler to 2.5.1 fix it? I've had that issue because I did an |
Confirmed this is a compiler bug, I made a reproduction here: https://stackblitz.com/edit/github-c7fcrc-tftu1q?file=src%2Fpages%2Findex.astro Reverting back to |
Downgrading fixes the issue on the repro environment, it's probably some issue with the last release where #950 was closed. It should be reopened imo |
@MoustaphaDev I think something went south on this PR: withastro/astro#9605. |
Thanks for reporting! This seems related to #955, we'll make sure to get this fixed as soon as possible. |
It happens thanks a lot! |
…" (#963) * test(#955): add failing test * test(#955): add another failing test * test: whoops it actually passes * Revert "Fix slot regression when there are multiple expressions (#952)" This reverts commit 418558c. * Revert "Fix various issues with slots (#933)" This reverts commit db13db9. * chore: changeset * chore: remove slot parens in test * test: update test * chore: remove slot parens in test * test: add test for #959 --------- Co-authored-by: Nate Moore <[email protected]>
Thank you! How will I know when this is live in the next release? |
Astro Info
If this issue only occurs in one browser, which browser is a problem?
No response
Describe the Bug
After upgrading to 4.3.2 slots appear to be broken if components are rendered within a map.
This is super weird as this approach I am using has been always working.
See Discord support ticket too.
What's the expected result?
We should get both "Hero" and "Component2" on the screen. Nothing before the last item in the switch statement is rendered, even statically added Astro elements.
Link to Minimal Reproducible Example
https://stackblitz.com/~/edit/github-c7fcrc
Participation
The text was updated successfully, but these errors were encountered: