Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lit): pin last lit 2.x compatible versions #8826

Merged
merged 4 commits into from
Oct 16, 2023
Merged

fix(lit): pin last lit 2.x compatible versions #8826

merged 4 commits into from
Oct 16, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Oct 13, 2023

Changes

Testing

Existing tests should pass. I would've expected them to be failing but maybe the lockfile kept CI passing.

Docs

Does not affect usage.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: 594bac6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) labels Oct 13, 2023
@lilnasy
Copy link
Contributor Author

lilnasy commented Oct 13, 2023

Using pnpm, @lit-labs/ssr still tries to install an incompatible version (1.1.4) of @lit-labs/ssr-client, even though the directly installed version (1.1.3) is compatible and matches the semver.

image

Edit: fixed with the override field.

@lilnasy lilnasy marked this pull request as ready for review October 13, 2023 16:34
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arsh gave me the context on Discord and this seems to be the best solution. Unfortunate that it's needed at all

@ematipico ematipico merged commit 754c40f into main Oct 16, 2023
13 checks passed
@ematipico ematipico deleted the fix/8825 branch October 16, 2023 08:53
@astrobot-houston astrobot-houston mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@astrojs/lit | this._$Ej.forEach is not a function
3 participants