Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@astrojs/lit] lit 3.0 compatibility #8822

Merged
merged 8 commits into from
Dec 12, 2023
Merged

[@astrojs/lit] lit 3.0 compatibility #8822

merged 8 commits into from
Dec 12, 2023

Conversation

Geoffrey-Pliez
Copy link
Contributor

@Geoffrey-Pliez Geoffrey-Pliez commented Oct 13, 2023 •
edited
Loading

Changes

upgrade to lit 3.0

Testing

Tested with npm command test from package.json

Docs

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 49c4cea

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) labels Oct 13, 2023
ematipico
ematipico reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could update the "Testing" part of the template and tell us how you tested the PR.

packages/integrations/lit/package.json Outdated
"parse5": "^7.1.2"
},
"devDependencies": {
"astro": "workspace:*",
"astro-scripts": "workspace:*",
"chai": "^4.3.7",
"chai": "^4.3.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this change? It's not part of the original intent of the PR

packages/integrations/lit/package.json Outdated
"mocha": "^10.2.0",
"sass": "^1.66.1"
"sass": "^1.69.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this change? It's not part of the original intent of the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's done ;)

lilnasy
lilnasy previously requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@lilnasy lilnasy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much requested feature! Thank you for working on this.

I'm going to block this until we merge and release a version of @astrojs/lit that continues to work with lit@^2.

Users could then upgrade their projects from lit 2.0 to 3.0 at their own pace.

@lilnasy lilnasy dismissed their stale review October 16, 2023 22:01

A working adapter version for lit 2.x now exists

@matthewp
Copy link
Contributor

@lilnasy if no one is working on fix for the old version then I think we should just go ahead and release this.

@lilnasy
Copy link
Contributor

lilnasy commented Nov 10, 2023

The fix landed and was released as the linked PRs show, and I dismissed my review when it did. I am not blocking this.

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 12, 2023
@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Dec 12, 2023
@matthewp matthewp merged commit b0a7194 into withastro:main Dec 12, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilnasy lilnasy Awaiting requested review from lilnasy

@ematipico ematipico Awaiting requested review from ematipico

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Geoffrey-Pliez @matthewp @lilnasy @ematipico