Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@astrojs/lit] lit 3.0 compatibility #8822

Merged
merged 8 commits into from
Dec 12, 2023
Merged

[@astrojs/lit] lit 3.0 compatibility #8822

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5cc0d58
updates packages
Geoffrey-Pliez Oct 13, 2023
981713b
[Fix] pnpm-lock
Geoffrey-Pliez Oct 13, 2023
84a7c53
[Fix] updates
Geoffrey-Pliez Oct 13, 2023
76a33b0
revert dev dependencies
Geoffrey-Pliez Oct 13, 2023
08a12c6
Merge branch 'main' into Update-lit-3.0
matthewp Dec 12, 2023
2694f28
Update lockfile
matthewp Dec 12, 2023
7236d49
Update lit version in the e2e tests
matthewp Dec 12, 2023
49c4cea
Adding changeset
matthewp Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/integrations/lit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,25 +42,25 @@
"test": "mocha"
},
"dependencies": {
"@lit-labs/ssr": "^3.1.5",
"@lit-labs/ssr-client": "^1.1.3",
"@lit-labs/ssr-dom-shim": "^1.1.1",
"@lit-labs/ssr": "^3.1.8",
"@lit-labs/ssr-client": "^1.1.4",
"@lit-labs/ssr-dom-shim": "^1.1.2",
"parse5": "^7.1.2"
},
"devDependencies": {
"astro": "workspace:*",
"astro-scripts": "workspace:*",
"chai": "^4.3.7",
"chai": "^4.3.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this change? It's not part of the original intent of the PR

"cheerio": "1.0.0-rc.12",
"lit": "^2.8.0",
"lit": "^3.0.0",
"mocha": "^10.2.0",
"sass": "^1.66.1"
"sass": "^1.69.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this change? It's not part of the original intent of the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's done ;)

},
"peerDependencies": {
"@webcomponents/template-shadowroot": "^0.2.1",
"lit": "^2.7.0"
"lit": "^3.0.0"
},
"publishConfig": {
"provenance": true
}
}
}
2 changes: 1 addition & 1 deletion packages/integrations/lit/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function getViteConfiguration() {
'@astrojs/lit/client-shim.js',
'@astrojs/lit/hydration-support.js',
'@webcomponents/template-shadowroot/template-shadowroot.js',
'lit/experimental-hydrate-support.js',
"@lit-labs/ssr-client/lit-element-hydrate-support.js",
],
exclude: ['@astrojs/lit/server.js'],
},
Expand Down
Loading