Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade lit library to v3 #9915

Merged
merged 4 commits into from
Feb 1, 2024
Merged

fix: upgrade lit library to v3 #9915

merged 4 commits into from
Feb 1, 2024

Conversation

shaal
Copy link
Contributor

@shaal shaal commented Jan 31, 2024

related: #8826
fixes: #9914

Changes

  • update framework-lit dependency of lit to version 3

Testing

I ran yarn install on framework-lit, and I no longer see the errors.

Docs

This does not affect user's behavior. No docs update is required.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 752062b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Jan 31, 2024
natemoo-re
natemoo-re approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No changeset needed, create-astro automatically pulls from the repo.

@bluwy bluwy merged commit 2f448a2 into withastro:main Feb 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The example framework-lit - displays an error - this._$Ej.forEach is not a function
4 participants
@shaal @natemoo-re @florian-lefebvre @bluwy