Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update [email protected] #10267

Closed
wants to merge 1 commit into from

Conversation

aleksandrjet
Copy link
Contributor

@aleksandrjet aleksandrjet commented Feb 28, 2024

Changes

While working on PR I noticed that the [email protected] update breaks the tests and the build. A similar problem was fixed here pr:8826.

The current solution is to add dependencies from lit to integrations/lit:

"@lit/reactive-element": "^2.0.4",
"lit-element": "^4.0.4",
"lit-html": "^3.1.2"

Without adding dependencies, tests fail, after adding everything is ok

Testing

Existing tests are sufficient to verify

Docs

I don't think documentation is needed for this. This does not have any side-effects, because these new dependencies will be installed with lit

Copy link

changeset-bot bot commented Feb 28, 2024

🦋 Changeset detected

Latest commit: 91dc9de

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandrjet aleksandrjet marked this pull request as draft February 28, 2024 17:09
@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Feb 28, 2024
@aleksandrjet aleksandrjet marked this pull request as ready for review February 29, 2024 09:27
@aleksandrjet aleksandrjet changed the title update [email protected] fix: update [email protected] Feb 29, 2024
@aleksandrjet
Copy link
Contributor Author

@florian-lefebvre
Copy link
Member

Looks like lit's version is now 3.1.3 (https://github.com/withastro/astro/blob/main/packages/integrations/lit/package.json#L59) and tests are not failing so I'm closing this PR as well as the error demo PR. Feel free to reopen if you think I'm wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants