Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review entire header for design consistency #299

Closed
14 of 15 tasks
kainino0x opened this issue Jun 5, 2024 · 2 comments
Closed
14 of 15 tasks

Review entire header for design consistency #299

kainino0x opened this issue Jun 5, 2024 · 2 comments

Comments

@kainino0x
Copy link
Collaborator

kainino0x commented Jun 5, 2024

Once we have most of the outstanding changes applied, we should make sure things look consistent. I think we have resolved most of the inconsistencies already but probably some of them aren't implemented yet.

@kainino0x kainino0x added the needs exploration Needs offline exploration (e.g. in an implementation) label Jun 6, 2024
@kainino0x
Copy link
Collaborator Author

kainino0x commented Nov 12, 2024

Working on this, posting notes as I go.

  • WGPUDeviceLostCallback takes arguments in a slightly odd order: device, reason, message, userdata1/2. To be consistent it would probably be either:
    • status, reason, message, device, userdata1/2
      where status = Success(??), FailedCreation and reason = Unknown, Destroyed, InstanceDropped.
      Splits status and reason similar to WGPUPopErrorScopeStatus, but "status" doesn't really make sense as this isn't the "return status" of an async operation like the others.
    • reason, message, device, userdata1/2 (just shuffling the order from what we have today).
      While this makes a little more sense, it does not seem at all worth changing from what we have now.

@kainino0x
Copy link
Collaborator Author

OK, done, filed a bunch of issues and linked them above.

@kainino0x kainino0x removed the needs exploration Needs offline exploration (e.g. in an implementation) label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant